-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix notification module #45823
Add matrix notification module #45823
Conversation
The test
The test
The test
The test
The test
The test
The test
The test
The test
|
Looks like I've still got some work to do :D |
The test
The test
The test
The test
The test
The test
The test
|
@jcgruenhage it is a lot easier and quicker to run the sanity tests locally. This saves you waiting for Shippable to run and you can run individual sanity tests instead of the whole bunch. To do this you can run
You can double up on tests by appending more
|
Oh cool, thanks 👍 |
@jborean93 In what directory are these supposed to be run? If run in the repository root I get a bunch of things for packages in the venv and in the directory of the module it fails to run.. |
@jcgruenhage it's best to run |
I did that. In the root of the repository I get a bunch of these:
They clearly don't matter, because it's venv packages and not what I am contributing. If I run it in the directory of the module I'm contributing, I get this:
|
The test
The test
The test
The test
The test
The test
The test
The test
|
@Deepakkothandan @Jmainguy @bjolivot @bkimble @drew-russell @fabulops @garbled1 @jcftang @jpmens @makaimc @mcodd @mpdehaan @pb8226 @shirou @tksmd @tonyseek @tyouxa @weaselkeeper @willybarro @zimbatm As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
It's been a while, is there anything more I can do aside from sending a "bump" comment every now and then? |
I have found asking for a review in #ansible-devel on the Freenode IRC has been helpful in moving things along. I don't have a matrix account or time to test this right now, but someone else in that channel likely will. |
I'll try that, thanks |
msg_html: | ||
description: | ||
- HTML form of the message to send to matrix | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would have single 'msg' and then a 'type' option, this follows the pattern of other modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be fit if the message sent contains either a plain text or an html message. Matrix sends both, a plain text variant (usually markdown) and also an HTML variant in the content of a text message event, unless there is no formatting (then the HTML variant is omitted). Because of that, the two different args are required as is.
description: | ||
- The password to log in with | ||
notes: | ||
- Requires matrix-client on the executing host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add 'python library' , then the 'pip install' becomes redundant, some people cannot use pip to install libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was adapted from pushbullet.py, but you're concern is definitely valid, will change it.
Thanks for this PR. Few minor things that are easier for me to just fix, than explain and get you to fix. * We suggest using `- name:` for examples, as Ansible best practice is to name your tasks * To prevent secrets being leaked out use `no_log` in argspec * use `requirements:` in `DOCUMENTATION`
The test
The test
The test
The test
The test
The test
|
The test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for the prompt fixes
Thank you for the new module. It's been merged into |
* Add matrix notification module * try to make ansibot happy * docs * fix typo in encoding * is ansibot happy now? * change matrix python lib requirement description * Example formatting & no_log Thanks for this PR. Few minor things that are easier for me to just fix, than explain and get you to fix. * We suggest using `- name:` for examples, as Ansible best practice is to name your tasks * To prevent secrets being leaked out use `no_log` in argspec * use `requirements:` in `DOCUMENTATION` * Clean up argument requirements * Remove requirements duplicate * not sure on syntax with these, were adapted from an example elsewhere
SUMMARY
This is a matrix notification module, to live alongside telegram, slack and the rest of the crowd.
ISSUE TYPE
COMPONENT NAME
matrix
ANSIBLE VERSION