Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about the query filters in NetBox dynamic inventory plugin #45835

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Add documentation about the query filters in NetBox dynamic inventory plugin #45835

merged 1 commit into from
Sep 21, 2018

Conversation

remyleone
Copy link
Contributor

SUMMARY

Add documentation about the query filters in NetBox dynamic inventory plugin

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • lib/ansible/plugins/inventory/netbox.py
ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. inventory Inventory category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/inventory/netbox.py:81:119: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 19, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 19, 2018
@acozine acozine added this to Docsite work in Ansible-maintained Collections Documentation via automation Sep 20, 2018
@acozine acozine added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Sep 20, 2018
samccann
samccann suggested changes Sep 21, 2018
View reviewed changes
lib/ansible/plugins/inventory/netbox.py Outdated Show resolved Hide resolved
lib/ansible/plugins/inventory/netbox.py Outdated Show resolved Hide resolved
lib/ansible/plugins/inventory/netbox.py Outdated Show resolved Hide resolved
lib/ansible/plugins/inventory/netbox.py Outdated Show resolved Hide resolved
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 21, 2018
@remyleone
Copy link
Contributor Author

@samccann done :)

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 21, 2018
@remyleone
Copy link
Contributor Author

shipit

@samccann samccann merged commit 574ed8d into ansible:devel Sep 21, 2018
Ansible-maintained Collections Documentation automation moved this from Docsite work to Done Sep 21, 2018
@samccann
Copy link
Contributor

Thanks @sieben for improving the Ansible documentation!

@remyleone
Copy link
Contributor Author

Thanks for the review :-)

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees

@samccann samccann

Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. inventory Inventory category networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
Ansible-maintained Collections Docume...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@remyleone @ansibot @samccann @acozine