Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-smart-quotes: Skip files by path in code-smell #45881

Merged
merged 2 commits into from
Dec 18, 2018
Merged

no-smart-quotes: Skip files by path in code-smell #45881

merged 2 commits into from
Dec 18, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Sep 20, 2018 •
edited

SUMMARY

This is to ensure the generated docs do not trigger more than 27000 code-smell issues on contributor systems.

The below endless list:

Sanity check using no-smart-quotes
ERROR: Found 27518 no-smart-quotes issue(s) which need to be resolved:
ERROR: docs/docsite/_build/html/api/index.html:592:156: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:617:112: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:874:148: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:989:165: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:1161:120: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:1653:154: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:1654:157: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:2082:132: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/api/index.html:2084:128: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/cli/ansible-config.html:594:156: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/cli/ansible-config.html:619:112: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/cli/ansible-config.html:874:148: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: docs/docsite/_build/html/cli/ansible-config.html:989:165: use ASCII quotes `'` and `"` instead of Unicode quotes
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

no-smart-quotes code-smell

ANSIBLE VERSION

v2.8

@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 20, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2018
mattclay
mattclay previously requested changes Sep 20, 2018
View reviewed changes
test/sanity/code-smell/no-smart-quotes.py Outdated Show resolved Hide resolved
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 20, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 28, 2018
@dagwieers
no-smart-quotes: Skip files by path in code-smell
d882b10 
This is to ensure the generated docs do not trigger code-smell issues on
contributor systems.
@dagwieers dagwieers dismissed mattclay’s stale review December 18, 2018 12:08

This is now implemented.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 18, 2018
@dagwieers
Copy link
Contributor Author

Please review!

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 18, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 18, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 18, 2018
@dagwieers dagwieers merged commit 7fb1a71 into ansible:devel Dec 18, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@dagwieers @kbreit
no-smart-quotes: Skip files by path in code-smell (ansible#45881)
4917604 
* no-smart-quotes: Skip files by path in code-smell

This is to ensure the generated docs do not trigger code-smell issues on
contributor systems.

* Implement feedback from review
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@gundalow gundalow Awaiting requested review from gundalow

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @mattclay @jborean93