Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test suite for ec2_vpc_igw before boto3 upgrade #45903

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Add test suite for ec2_vpc_igw before boto3 upgrade #45903

merged 1 commit into from
Oct 4, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

Checks results of ec2_vpc_igw is same before and after boto3 upgrade

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_igw

ANSIBLE VERSION
ansible 2.8.0.dev0 (devel 5c73d4f4bd) last updated 2018/09/20 19:53:36 (GMT +1000)
  config file = None
  configured module search path = [u'/Users/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/will/src/ansible/lib/ansible
  executable location = /Users/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar  9 2018, 23:57:12) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
ADDITIONAL INFORMATION

@willthames
Copy link
Contributor Author

Teset suite for #45346

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. labels Sep 20, 2018
@willthames willthames mentioned this pull request Sep 20, 2018
Merged
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 21, 2018
s-hertel
s-hertel reviewed Sep 21, 2018
View reviewed changes
test/integration/targets/ec2_vpc_igw/aliases Outdated
@@ -0,0 +1,2 @@
cloud/aws
unsupported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test suite would run fine in CI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And off the top of my head I don't think it would need any added permissions

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 2, 2018
@s-hertel
Copy link
Contributor

s-hertel commented Oct 4, 2018

Thanks for adding the tests!

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 4, 2018
@ansibot ansibot merged commit aec263d into ansible:devel Oct 4, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willthames @s-hertel @ansibot