Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix os_router ignores enable_snat: no #45921

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Fix os_router ignores enable_snat: no #45921

merged 1 commit into from
Oct 10, 2018

Conversation

dominikholler
Copy link
Contributor

@dominikholler dominikholler commented Sep 20, 2018 •
edited

SUMMARY

If enable_snat is False, this should be used to build the
request, because of the default value in the OpenStack Networking
API is True.

Fixes #45915

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_router

ANSIBLE VERSION
ADDITIONAL INFORMATION

@dominikholler
Fix os_router ignores enable_snat: no
07b81ad 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue ansible#45915.
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 20, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 20, 2018

Build succeeded (third-party-check pipeline).

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 21, 2018
@guilhermesteinmuller
Copy link
Contributor

That's great! Let's backport it as soon as it's merged in devel!

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 29, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 7, 2018
@Shrews Shrews merged commit 452a4ab into ansible:devel Oct 10, 2018
dominikholler added a commit to dominikholler/ansible that referenced this pull request Oct 12, 2018
@dominikholler
Fix os_router ignores enable_snat: no (ansible#45921)
c254dd8 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue ansible#45915.

(cherry picked from commit 452a4ab)
dominikholler added a commit to dominikholler/ansible that referenced this pull request Oct 12, 2018
@dominikholler
Fix os_router ignores enable_snat: no (ansible#45921)
84fcb4a 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue ansible#45915.

(cherry picked from commit 452a4ab)
abadger pushed a commit that referenced this pull request Oct 12, 2018
@dominikholler @abadger
Fix os_router ignores enable_snat: no (#45921)
9a2e192 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue #45915.

(cherry picked from commit 452a4ab)
mattclay pushed a commit that referenced this pull request Oct 16, 2018
@dominikholler @mattclay
Fix os_router ignores enable_snat: no (#45921)
b550320 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue #45915.

(cherry picked from commit 452a4ab)
luis5tb pushed a commit to luis5tb/ansible that referenced this pull request Oct 24, 2018
@dominikholler @luis5tb
Fix os_router ignores enable_snat: no (ansible#45921)
7e7a82d 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue ansible#45915.

(cherry picked from commit 452a4ab)
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@dominikholler @Tomorrow9
Fix os_router ignores enable_snat: no (ansible#45921)
cf0709e 
If enable_snat is False, this should be used to build the
request, because the default value in the OpenStack Networking
API is True.

Fixes the issue ansible#45915.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. openstack small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_router ignores enable_snat: no
5 participants
@dominikholler @ansibot @guilhermesteinmuller @Shrews @mkrizek