Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after ansible-connection if failure occurred in start() #45929

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 20, 2018

SUMMARY

Fixes #44673

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-connection

ANSIBLE VERSION
2.8

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 20, 2018
@Qalthos Qalthos merged commit 0d143ed into ansible:devel Sep 20, 2018
Qalthos added a commit to Qalthos/ansible that referenced this pull request Sep 20, 2018
ansible#45929)

(cherry picked from commit 0d143ed)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
Qalthos added a commit to Qalthos/ansible that referenced this pull request Sep 20, 2018
ansible#45929)

(cherry picked from commit 0d143ed)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
@Qalthos Qalthos deleted the fail-in-start branch September 20, 2018 19:07
@Qalthos Qalthos moved this from In Review to Done in zzz NOT USED: Networking Bugs Sep 20, 2018
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Sep 21, 2018
mattclay pushed a commit that referenced this pull request Sep 25, 2018
#45929)

(cherry picked from commit 0d143ed)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
abadger pushed a commit that referenced this pull request Oct 10, 2018
#45930)

* [2.7] Clean up after ansible-connection if failure occurred in start() (#45929)
(cherry picked from commit 0d143ed)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>

* Add changelog fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

persistent connection remains after premature/unexpected/interrupted playbook run
3 participants