Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: Introduce VxLan #45932

Merged
merged 1 commit into from
Oct 30, 2018
Merged

nmcli: Introduce VxLan #45932

merged 1 commit into from
Oct 30, 2018

Conversation

ssahani
Copy link
Contributor

@ssahani ssahani commented Sep 20, 2018 •
edited 

  - nmcli:
      type: vxlan
      conn_name: vxlan_test1
      vxlan_id: 16
      vxlan_local: 192.168.1.2
      vxlan_remote: 192.168.1.5

Signed-off-by: Susant Sahani susant@redhat.com

SUMMARY

This work enables to add vxlan via nmcli module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nmcli

ANSIBLE VERSION
ansible 2.8.0
ADDITIONAL INFORMATION
- nmcli:
      type: vxlan
      conn_name: vxlan_test1
      vxlan_id: 16
      vxlan_local: 192.168.1.2
      vxlan_remote: 192.168.1.5

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:510:15: duplicate-key Duplicate key 15 in dictionary

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/net_tools/nmcli.py:1111:23: E203 whitespace before ':'
lib/ansible/modules/net_tools/nmcli.py:1133:29: E203 whitespace before ':'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/nmcli.py:0:0: missing documentation (or could not parse documentation): pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/net_tools/nmcli.py:1111:23: E203 whitespace before ':'
lib/ansible/modules/net_tools/nmcli.py:1133:29: E203 whitespace before ':'

click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/net_tools/nmcli.py:0:0: E309 version_added for new option (vxlan_id) should be 2.8. Currently 0.0
lib/ansible/modules/net_tools/nmcli.py:0:0: E309 version_added for new option (vxlan_local) should be 2.8. Currently 0.0
lib/ansible/modules/net_tools/nmcli.py:0:0: E309 version_added for new option (vxlan_remote) should be 2.8. Currently 0.0
lib/ansible/modules/net_tools/nmcli.py:0:0: E326 Value for "choices" from the argument_spec (['ethernet', 'team', 'team-slave', 'bond', 'bond-slave', 'bridge', 'bridge-slave', 'vlan', 'vxlan', 'generic']) for "type" does not match the documentation (['ethernet', 'team', 'team-slave', 'bond', 'bond-slave', 'bridge', 'bridge-slave', 'vlan', 'generic'])

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/net_tools/nmcli.py:0:0: E309 version_added for new option (vxlan_id) should be 2.8. Currently 0.0
lib/ansible/modules/net_tools/nmcli.py:0:0: E309 version_added for new option (vxlan_local) should be 2.8. Currently 0.0
lib/ansible/modules/net_tools/nmcli.py:0:0: E309 version_added for new option (vxlan_remote) should be 2.8. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 20, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 21, 2018
@Akasurde
Copy link
Member

@ssahani Thanks for the contribution. Changes LGTM. Could you please write a test for this change here - https://github.com/ansible/ansible/blob/devel/test/units/modules/net_tools/test_nmcli.py ? Thanks.

@Akasurde Akasurde self-requested a review September 27, 2018 14:54
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Sep 27, 2018
nmcli: Introduce VxLan
878d4f3 
This work enables to add vxlan via nmcli module

```
  - nmcli:
      type: vxlan
      conn_name: vxlan_test1
      vxlan_id: 16
      vxlan_local: 192.168.1.2
      vxlan_remote: 192.168.1.5
```
ansible 2.8.0

revision 1: Added tests

Signed-off-by: Susant Sahani <susant@redhat.com>
@ssahani
Copy link
Contributor Author

ssahani commented Sep 28, 2018

@Akasurde thanks for the review. Updated

@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 6, 2018
@ssahani
Copy link
Contributor Author

ssahani commented Oct 26, 2018

@Akasurde Ping

Akasurde
Akasurde approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde
Copy link
Member

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 30, 2018
@ansibot ansibot merged commit 2596ac1 into ansible:devel Oct 30, 2018
@ssahani
Copy link
Contributor Author

ssahani commented Oct 30, 2018

Thanks for merging @Akasurde !

@ssahani ssahani deleted the ansible-nmcli-vxlan branch October 30, 2018 08:47
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@ssahani @Tomorrow9
nmcli: Introduce VxLan (ansible#45932)
bc2315b 
This work enables to add vxlan via nmcli module

```
  - nmcli:
      type: vxlan
      conn_name: vxlan_test1
      vxlan_id: 16
      vxlan_local: 192.168.1.2
      vxlan_remote: 192.168.1.5
```
ansible 2.8.0

revision 1: Added tests

Signed-off-by: Susant Sahani <susant@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ssahani @ansibot @Akasurde @s-hertel