nmcli: Introduce SIT Tunnel #45937
Merged
nmcli: Introduce SIT Tunnel #45937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
The test |
ansibot
added
ci_verified
s-hertel
removed
the
needs_triage
Akasurde
requested changes
Sep 27, 2018
There was a problem hiding this comment.
Thanks for the contribution. Could you please write a test for this change here - https://github.com/ansible/ansible/blob/devel/test/units/modules/net_tools/test_nmcli.py ? Thanks.
| @@ -1066,6 +1089,61 @@ def modify_connection_vlan(self): | |||
|
|
|||
| return cmd | |||
|
|
|||
| def create_connection_sit(self): | |||
| cmd = [self.nmcli_bin] | |||
There was a problem hiding this comment.
cmd = [self.nmcli_bin, 'con', 'add', 'type', 'ip-tunnel', 'mode', 'sit', 'con-name']There was a problem hiding this comment.
yes sure . updated.
| return cmd | ||
|
|
||
| def modify_connection_sit(self): | ||
| cmd = [self.nmcli_bin] |
There was a problem hiding this comment.
cmd = [self.nmcli_bin, 'con', 'mod']
ansibot
added
needs_revision
|
I have updated not sure how to run these tests locally ? |
|
@ssahani You can run tests locally using following command - |
|
Thanks apparently I am missing something Ok I fixed it will fix the test cases |
ansibot
added
needs_ci
|
@Akasurde Thanks for reviewing. Seems all tests passed. |
ansibot
added
needs_maintainer
ansibot
added
stale_review
|
@Akasurde Ping |
|
@ssahani Could you please rebase this ? needs_info |
ansibot
added
needs_info
|
Thanks for looking into it. I have updated #45933 . SInce again be a be conflict once IPIP PR get merged I will rebase it. |
ansibot
removed
the
needs_info
ansibot
removed
the
needs_maintainer
ansibot
removed
needs_rebase
|
The test The test The test The test The test The test The test The test The test The test |
This work enables to add sit tunnel via nmcli module
Signed-off-by: Susant Sahani susant@redhat.com
SUMMARY
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
nmcli
ANSIBLE VERSION
2.8
ADDITIONAL INFORMATION
- nmcli:
state: present
type: sit
conn_name: sit_test1
autoconnect: yes
ip_tunnel_dev: enp0s8
ip_tunnel_local: 192.168.1.2
ip_tunnel_remote: 192.168.1.5
|
@Akasurde Thanks updated. |
Akasurde
approved these changes
Nov 18, 2018
ansibot
added
core_review
ansibot
added
the
stale_ci
|
rebuild_merge |
ansibot
removed
the
stale_ci
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
This work enables to add sit tunnel via nmcli module
Signed-off-by: Susant Sahani susant@redhat.com
SUMMARY
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
nmcli
ANSIBLE VERSION
2.8
ADDITIONAL INFORMATION
- nmcli:
state: present
type: sit
conn_name: sit_test1
autoconnect: yes
ip_tunnel_dev: enp0s8
ip_tunnel_local: 192.168.1.2
ip_tunnel_remote: 192.168.1.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work enables to add sit tunnel via nmcli module
Signed-off-by: Susant Sahani susant@redhat.com
SUMMARY
ISSUE TYPE
COMPONENT NAME
nmcli
ANSIBLE VERSION
ADDITIONAL INFORMATION