Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: new module vmware_host_feature_facts #45966

Merged
merged 1 commit into from
Oct 8, 2018
Merged

VMware: new module vmware_host_feature_facts #45966

merged 1 commit into from
Oct 8, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_host_feature_facts.py
test/integration/targets/vmware_host_feature_facts/aliases
test/integration/targets/vmware_host_feature_facts/tasks/main.yml

ANSIBLE VERSION
2.8-devel

@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2018

cc @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Sep 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_host_feature_facts.py:87:5: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_host_feature_facts.py:87:5: error RETURN: syntax error: expected the node content, but found '}'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 21, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 21, 2018
@Akasurde
VMware: new module vmware_host_feature_facts
fbc7fc8 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde force-pushed the vmware_host_feature_capability_facts branch from 6978b95 to fbc7fc8 Compare September 21, 2018 08:22
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2018

@MikeKlebolt @bedecarroll @CastawayEGR @chrrrles @dav1x @garbled1 @imjoseangel @jjahns @kamsz @kryptsi @lrivallain @nafpliot-ibm @nerzhul @oboukili @pdellaert @rhoop @ritzk @rmin @stravassac @tchernomax @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 29, 2018
tchernomax
tchernomax approved these changes Oct 7, 2018
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 7, 2018
@Akasurde Akasurde merged commit 513be89 into ansible:devel Oct 8, 2018
@Akasurde Akasurde deleted the vmware_host_feature_capability_facts branch October 8, 2018 08:58
@Akasurde
Copy link
Member Author

Akasurde commented Oct 8, 2018

@tchernomax Thanks for the review. And Welcome back :)

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tchernomax tchernomax tchernomax approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @ansibot @tchernomax @mkrizek