Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing assigning ssl certificate to http listener in app gateway (#45… #46027

Merged
merged 2 commits into from Oct 15, 2018
Merged

Fixing assigning ssl certificate to http listener in app gateway (#45… #46027

merged 2 commits into from Oct 15, 2018

Conversation

zikalino
Copy link
Contributor

…830)

  • fixed ssl certificate reference

  • modified test

(cherry picked from commit 8364596)

SUMMARY

Backporting appgateway bug

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_appgateway

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

Fixing assigning ssl certificate to http listener in app gateway (#45830
b132ec5 
)

* fixed ssl certificate reference

* modified test

(cherry picked from commit 8364596)
@ansibot
Copy link
Contributor

ansibot commented Sep 22, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 22, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Sep 23, 2018
Closed
@Fred-sun
Copy link
Contributor

@nitzmahone @bcoca Could you help review this PR? Thanks!

@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Sep 25, 2018
@abadger
Copy link
Contributor

abadger commented Sep 27, 2018

This needs a changelog entry.

@yuwzho
Copy link
Contributor

yuwzho commented Sep 28, 2018

#45830

@yuwzho
Copy link
Contributor

yuwzho commented Sep 28, 2018 •
edited

@zikalino Please create a change log under changelogs/fragments

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 6, 2018
@Fred-sun
Copy link
Contributor

Fred-sun commented Oct 8, 2018

@zikalino

@abadger
Copy link
Contributor

abadger commented Oct 9, 2018

@zikalino, this needs a changelog entry before being merged. You can look at https://github.com/ansible/ansible/tree/stable-2.7/changelogs/fragments for examples of hte format.

@zikalino
Copy link
Contributor Author

@abadger added changelog, could you pls merge?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 15, 2018
@abadger abadger merged commit f16bb4d into ansible:stable-2.7 Oct 15, 2018
@abadger
Copy link
Contributor

abadger commented Oct 15, 2018

Merged for the 2.7.1 release.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zikalino @ansibot @Fred-sun @abadger @yuwzho @webknjaz