Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cs_instance: doc: fix typo in examples #46035

Merged
merged 3 commits into from
Sep 26, 2018
Merged

cs_instance: doc: fix typo in examples #46035

merged 3 commits into from
Sep 26, 2018

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Sep 22, 2018

SUMMARY

fixes sanity

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cs_instance

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 22, 2018

cc @dpassante @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud cloudstack core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 22, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 22, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E326 Value for "choices" from the argument_spec (['KVM', 'kvm', 'VMware', 'vmware', 'BareMetal', 'baremetal', 'XenServer', 'xenserver', 'LXC', 'lxc', 'HyperV', 'hyperv', 'UCS', 'ucs', 'OVM', 'ovm', 'Simulator', 'simulator']) for "hypervisor" does not match the documentation (['KVM', 'VMware', 'BareMetal', 'XenServer', 'LXC', 'HyperV', 'UCS', 'OVM', 'Simulator'])
lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E326 Value for "choices" from the argument_spec (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'no', 'pt', 'uk', 'us']) for "keyboard" does not match the documentation (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'False', 'pt', 'uk', 'us'])

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. labels Sep 22, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 22, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E326 Value for "choices" from the argument_spec (['KVM', 'kvm', 'VMware', 'vmware', 'BareMetal', 'baremetal', 'XenServer', 'xenserver', 'LXC', 'lxc', 'HyperV', 'hyperv', 'UCS', 'ucs', 'OVM', 'ovm', 'Simulator', 'simulator']) for "hypervisor" does not match the documentation (['KVM', 'VMware', 'BareMetal', 'XenServer', 'LXC', 'HyperV', 'UCS', 'OVM', 'Simulator'])
lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E326 Value for "choices" from the argument_spec (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'no', 'pt', 'uk', 'us']) for "keyboard" does not match the documentation (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'False', 'pt', 'uk', 'us'])

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 22, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E326 Value for "choices" from the argument_spec (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'no', 'pt', 'uk', 'us']) for "keyboard" does not match the documentation (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'False', 'pt', 'uk', 'us'])

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 22, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/cloudstack/cs_instance.py:0:0: E326 Value for "choices" from the argument_spec (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'no', 'pt', 'uk', 'us']) for "keyboard" does not match the documentation (['de', 'de-ch', 'es', 'fi', 'fr', 'fr-be', 'fr-ch', 'is', 'it', 'jp', 'nl-be', 'False', 'pt', 'uk', 'us'])

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 22, 2018
@gundalow
Copy link
Contributor

Discusses no != false on IRC, I suggest adding to ignore.txt for the moment

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 24, 2018
mattclay
mattclay reviewed Sep 24, 2018
View reviewed changes
lib/ansible/modules/cloud/cloudstack/cs_instance.py Outdated
@@ -77,11 +77,12 @@
- Name the hypervisor to be used for creating the new instance.
- Relevant when using I(state=present), but only considered if not set on ISO/template.
- If not set or found on ISO/template, first found hypervisor will be used.
choices: [ KVM, VMware, BareMetal, XenServer, LXC, HyperV, UCS, OVM, Simulator ]
choices: [KVM, kvm, VMware, vmware, BareMetal, baremetal, XenServer, xenserver, LXC, lxc, HyperV, hyperv, UCS, ucs, OVM, ovm, Simulator, simulator]
keyboard:
description:
- Keyboard device type for the instance.
choices: [ de, de-ch, es, fi, fr, fr-be, fr-ch, is, it, jp, nl-be, no, pt, uk, us ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote the no to avoid parsing as a bool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facepalm

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 24, 2018
@mattclay
Copy link
Member

The tests were unstable. I've restarted them. Assuming they pass, they may still warrant further investigation, as they're likely to be unstable in the future as well.

@resmo
Copy link
Contributor Author

resmo commented Sep 25, 2018

@mattclay I was able to reproduce the issue, it looks like a bug in cloudstack.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 25, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Sep 25, 2018
@resmo resmo merged commit c09b785 into ansible:devel Sep 26, 2018
@resmo resmo deleted the fix/cs_instance_doc branch September 26, 2018 07:02
@gundalow
Copy link
Contributor

Might be worth backporting this

@resmo
Copy link
Contributor Author

resmo commented Sep 26, 2018

preparing a couple of backports. Thanks!

abadger pushed a commit that referenced this pull request Oct 10, 2018
@resmo @abadger
[2.7] backport cs_instance fixes (#46274)
083d2a6 
* cs_instance: doc: fix typo in examples (#46035)


(cherry picked from commit c09b785)

* cs_instance: fix host migration without volume (#46115)


(cherry picked from commit e7926cf)

* add changelog fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud cloudstack core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@resmo @ansibot @gundalow @mattclay