Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typetalk.py to use com domain #46045

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Update typetalk.py to use com domain #46045

merged 1 commit into from
Sep 24, 2018

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Sep 23, 2018

+label: docsite_pr

SUMMARY

Typetalk now uses "com" domain.
FYI: https://www.typetalk.com/blog/typetalk-gets-new-top-level-domain-typetalk-com/

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

typetalk

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 23, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 24, 2018
@is2ei is2ei mentioned this pull request Sep 24, 2018
Closed
@is2ei
Copy link
Contributor Author

is2ei commented Sep 24, 2018

@dagwieers
I removed "( http://developers.typetalk.in/ )" since you mentioned that it is not necessarily information.
You suggested to move it to notes section, but I also think it's not necessarily information so I simply removed it. What do you think about it?

@acozine
Copy link
Contributor

acozine commented Sep 24, 2018

@is2ei thanks for catching the change in domain names, and for opening this PR!

@acozine acozine merged commit d8d4be4 into ansible:devel Sep 24, 2018
@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Sep 25, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@is2ei @acozine @dagwieers @webknjaz @ansibot