Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOTMETA.yml and module metadata: fix case authors #46051

Merged
merged 3 commits into from
Nov 19, 2018
Merged

BOTMETA.yml and module metadata: fix case authors #46051

merged 3 commits into from
Nov 19, 2018

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Sep 23, 2018 •
edited

SUMMARY

BOTMETA.yml and module author metadata: fix case authors

Links to related GitHub accounts:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

.github/BOTMETA.yml

ANSIBLE VERSION
ansible 2.8.0.dev0 (devel fc7e5f16e8) last updated 2018/09/21 23:55:01 (GMT +200)
ADDITIONAL INFORMATION

Some accounts are inexistent (i don't modify anything for them):

what should be done with them ? (cc @gundalow) I propose:

  • to replace @CloudEngine-Ansible by GitHub ID of the submitter;
  • for others, delete entry in author METADATA. (see comments)

@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2018

cc @bennojoy @erjohnso @haroldwongms @Java1Guy @kaczynskid @machacekondra @mwperina @nitaco @nitzmahone @rambleraptor @samdoran @trstringer @willthames @xscript @yuwzho @zacblazic @Zeekin @zikalino
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws azure bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 23, 2018
@gundalow
Copy link
Contributor

to replace @CloudEngine-Ansible by GitHub ID of the submitter;
for others, delete entry in author METADATA.
+1 from me

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 23, 2018
@pilou-
Copy link
Contributor Author

pilou- commented Sep 23, 2018

  • CloudEngine-Ansible have been replaced by GitHub ID of the submitter (it's quite odd, submitters and authors differ, nevertheless I used GitHub ID submitter)
  • nonexistent entries in author DOCUMENTATION metadata removed

@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2018

Thanks @pilou-! This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2018

Thanks @pilou-! This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@pilou- pilou- mentioned this pull request Sep 23, 2018
Merged
@ansibleazurebot ansibleazurebot mentioned this pull request Sep 24, 2018
Closed
@Fred-sun
Copy link
Contributor

@pilou- Thanks for the contribution, Could you help confirm the PR ready for review or not? If ready, I will push to review. Thanks!

@pilou-
Copy link
Contributor Author

pilou- commented Oct 18, 2018

Rebased

@pilou- pilou- mentioned this pull request Oct 18, 2018
Closed
dagwieers
dagwieers suggested changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be removing authors because their GitHub handle no longer works. We should at least keep their name listed as author, but I would go so far as add a comment with a notice that their GitHub handle not (no longer) exists. They are still the (original) author.

lib/ansible/modules/network/panos/panos_query_rules.py Outdated Show resolved Hide resolved
@pilou- pilou- force-pushed the botmeta_fix_case_authors branch 2 times, most recently from 2fd585a to c811327 Compare November 16, 2018 13:15
@gundalow
Copy link
Contributor

I was thinking more about this last night. I think I agree with Dag. Lets leave the authors details in.

We can extend validate-modules to validate the author parameter on module creation only

dagwieers
dagwieers suggested changes Nov 16, 2018
View reviewed changes
docs/bin/plugin_formatter.py Outdated Show resolved Hide resolved
@pilou-
Copy link
Contributor Author

pilou- commented Nov 16, 2018

ready_for_review

@dagwieers @gundalow updated

@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Nov 16, 2018
@gundalow
Copy link
Contributor

@pilou- Thank you for taking the time to fix this, and do the research to find the right accounts.

As this PR now just corrects typos I'm merging

@gundalow gundalow merged commit 7f98a8d into ansible:devel Nov 19, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@pilou- @mjmayer
BOTMETA.yml and module metadata: fix case authors (ansible#46051)
3ecdbe2 
* botmeta: fix GitHub ID case

* module authors: fix GitHub ID case

* replace CloudEngine-Ansible by submitter GitHub ID
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@pilou- @Tomorrow9
BOTMETA.yml and module metadata: fix case authors (ansible#46051)
5f78432 
* botmeta: fix GitHub ID case

* module authors: fix GitHub ID case

* replace CloudEngine-Ansible by submitter GitHub ID
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers requested changes

@ryansb ryansb ryansb approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws azure botmeta This PR modifies the BOTMETA.yml and this requires special attention! bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. gce module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pilou- @ansibot @gundalow @Fred-sun @dagwieers @ryansb