Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_host: Fix fail condititon of upgrade #46104

Merged
merged 1 commit into from
Sep 28, 2018
Merged

ovirt_host: Fix fail condititon of upgrade #46104

merged 1 commit into from
Sep 28, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

This PR changes the fail condition of host upgrade so it takes into account also the case when VM fails to migrate during upgrade.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_host

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 25, 2018
@machacekondra
ovirt_host: Fix fail condititon of upgrade
271064e 
Signed-off-by: Ondra Machacek <omachace@redhat.com>
mwperina
mwperina approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@machacekondra
Copy link
Contributor Author

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Sep 25, 2018
@gundalow gundalow merged commit 142d1f1 into ansible:devel Sep 28, 2018
@Shaps
Copy link
Contributor

Shaps commented Sep 28, 2018

👍 You just made the 40000th commit to Ansible! :D

@gundalow
Copy link
Contributor

Congratulations, this is the 40,000 commit to Ansible!

@mwperina
Copy link
Contributor

👍

@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machacekondra @ansibot @Shaps @gundalow @mwperina @dagwieers