Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_asg: Retry Autoscaling Group delete calls when scaling activity is in progress #46124

Merged
merged 2 commits into from
Nov 29, 2018
Merged

ec2_asg: Retry Autoscaling Group delete calls when scaling activity is in progress #46124

merged 2 commits into from
Nov 29, 2018

Conversation

ryansb
Copy link
Contributor

@ryansb ryansb commented Sep 25, 2018

SUMMARY

Sometimes when deleting an ASG, the marker for "scaling activity" is eventually consistent and can cause deletes to fail. This change enables retry for deleting ASGs that are in the process of scaling.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2018

cc @garethr @s-hertel
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:certified This issue/PR relates to certified code. labels Sep 25, 2018
@ryansb ryansb removed needs_triage Needs a first human triage before being processed. labels Sep 25, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 3, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed committer_review In order to be merged, this PR must follow the certified review workflow. support:certified This issue/PR relates to certified code. labels Oct 11, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 25, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 24, 2018
@gundalow gundalow changed the title [aws] Retry Autoscaling Group delete calls when scaling activity is in progress ec2_asg: Retry Autoscaling Group delete calls when scaling activity is in progress Nov 29, 2018
@gundalow
Copy link
Contributor

Will need a changelog fragment

@s-hertel s-hertel merged commit 7f7c059 into ansible:devel Nov 29, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryansb @ansibot @gundalow @s-hertel