Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user_agent into Pure Storage FlashBlade API calls #46221

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Add user_agent into Pure Storage FlashBlade API calls #46221

merged 1 commit into from
Oct 29, 2018

Conversation

sdodsley
Copy link
Contributor

SUMMARY

Add user_agent into FlashBlade API calls to allow tracking of Ansible modules managing FlashBlades

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils/pure.py

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]
ADDITIONAL INFORMATION

This will only be implemented if the FlasHblade is running REST v1.5 or higher

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 27, 2018
@sdodsley sdodsley changed the title Add user_agent into FlashBlade API calls Add user_agent into Pure Storage FlashBlade API calls Sep 27, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 27, 2018
@ansibot ansibot added owner_pr This PR is made by the module's maintainer. pure_storage stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 5, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 15, 2018

cc @genegr @lionmax @sile16
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

cc @bannaych @raekins
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 17, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 18, 2018
@sile16
Copy link

sile16 commented Oct 23, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 23, 2018
@gundalow
Copy link
Contributor

@sdodsley Thank you for the PR.
@sile16 Thank you for the review.

As this is a feature, merged into devel for release in Ansible 2.8

@gundalow gundalow merged commit bba8c23 into ansible:devel Oct 29, 2018
@sdodsley sdodsley deleted the fb_user_agent branch October 29, 2018 12:31
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@sdodsley @Tomorrow9
Add user_agent into FlashBlade API calls (ansible#46221)
1efa3fc
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sile16 sile16 sile16 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. owner_pr This PR is made by the module's maintainer. pure_storage shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sdodsley @ansibot @sile16 @gundalow @samdoran