Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] backport cs_instance fixes #46274

Merged
merged 3 commits into from
Oct 10, 2018
Merged

[2.7] backport cs_instance fixes #46274

merged 3 commits into from
Oct 10, 2018

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Sep 28, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cs_instance

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 28, 2018

cc @dpassante @mattclay
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud cloudstack core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 28, 2018
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Oct 1, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

@resmo: thank you for submitting this pull-request!

cc @rhtyd
click here for bot help

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 9, 2018
rohityadavcloud
rohityadavcloud approved these changes Oct 9, 2018
View reviewed changes
Copy link

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked against original PRs which were back ported.

@rohityadavcloud
Copy link

shipit

rohityadavcloud
rohityadavcloud approved these changes Oct 9, 2018
View reviewed changes
Copy link

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. shipit This PR is ready to be merged by Core labels Oct 9, 2018
@abadger
Copy link
Contributor

abadger commented Oct 9, 2018 •
edited

Merged for the 2.7.1 release.

EDIT: Shippable is failing will try rerunning shippable later to see if this is indeed ready to merge.

@abadger
Copy link
Contributor

abadger commented Oct 9, 2018

Errr.... Not yet merged. shippable is failing here. It may be a shippable problem, though, not a problem with the PR. I'll check back in later and see if I can restart the CI job and it will pass.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 9, 2018
@ansibot ansibot added the shipit This PR is ready to be merged by Core label Oct 9, 2018
@abadger abadger merged commit 083d2a6 into ansible:stable-2.7 Oct 10, 2018
@abadger
Copy link
Contributor

abadger commented Oct 10, 2018

Merged for the 2.7.1 release

@resmo resmo deleted the backport/2.7/cloudstack branch October 10, 2018 07:25
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud cloudstack module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@resmo @ansibot @rohityadavcloud @abadger @bcoca