win_reboot: Fix for ignore post_reboot_delay #46360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagwieers
added
windows
ansibot
added
affects_2.8
dagwieers
force-pushed
the
win_reboot-fix
branch
from
3930fc6
to
f5ff173
Compare
ansibot
added
needs_revision
samdoran
suggested changes
Oct 1, 2018
ansibot
added
the
needs_revision
This fixes an issue where win_reboot would be ignoring the provided post_reboot_delay (and on Windows timing/waiting is everything!) This must be backported to the v2.7 branch.
dagwieers
force-pushed
the
win_reboot-fix
branch
from
f5ff173
to
528014b
Compare
jborean93
reviewed
Oct 2, 2018
ansibot
added
needs_ci
dagwieers
force-pushed
the
win_reboot-fix
branch
from
9a28fd9
to
6580a6c
Compare
ansibot
removed
needs_ci
samdoran
suggested changes
Oct 2, 2018
dagwieers
force-pushed
the
win_reboot-fix
branch
from
6580a6c
to
81f0d67
Compare
dagwieers
force-pushed
the
win_reboot-fix
branch
from
81f0d67
to
da3383f
Compare
jborean93
approved these changes
Oct 4, 2018
samdoran
suggested changes
Oct 4, 2018
samdoran
approved these changes
Oct 4, 2018
samdoran
pushed a commit
to samdoran/ansible
that referenced
this pull request
Oct 4, 2018
* win_reboot: Fix for ignore post_reboot_delay This fixes an issue where win_reboot would be ignoring the provided post_reboot_delay (and on Windows timing/waiting is everything!) This must be backported to the v2.7 branch. * Merge post-reboot handling into run() (cherry picked from commit 8c64b4a)
abadger
pushed a commit
that referenced
this pull request
Oct 11, 2018
* win_reboot: Fix for ignore post_reboot_delay (#46360) * win_reboot: Fix for ignore post_reboot_delay This fixes an issue where win_reboot would be ignoring the provided post_reboot_delay (and on Windows timing/waiting is everything!) This must be backported to the v2.7 branch. * Merge post-reboot handling into run() (cherry picked from commit 8c64b4a) * Add a changelog for the win_reboot fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes an issue where win_reboot would be ignoring the provided
post_reboot_delay (and on Windows timing/waiting is everything!)
This must be backported to the v2.7 branch.
ISSUE TYPE
COMPONENT NAME
win_reboot
ANSIBLE VERSION
v2.7 and newer