Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User module - allow bang and exclamation in password field without warning #46498

Merged
merged 2 commits into from
Nov 5, 2018
Merged

User module - allow bang and exclamation in password field without warning #46498

merged 2 commits into from
Nov 5, 2018

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Oct 4, 2018

SUMMARY

Allow the password field to be only ! or * without warning when using this feature to create accounts that are locked.

Add documentation and tests to cover this.

Fixes #46334

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

user.py

ANSIBLE VERSION
2.8
2.7

@samdoran samdoran force-pushed the issue/46334-user-disable-account branch from 719044a to c95e47a Compare October 4, 2018 16:43
@ansibot
Copy link
Contributor

ansibot commented Oct 4, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:446:54: SyntaxError: if self.module.params['password'] in {'*', '!'}:

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:446:54: SyntaxError: invalid syntax

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 4, 2018

cc @sfromm
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
@samdoran samdoran force-pushed the issue/46334-user-disable-account branch from 0af2aee to 34f9648 Compare October 4, 2018 20:39
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 4, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 4, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 12, 2018
@samdoran samdoran mentioned this pull request Oct 15, 2018
Closed
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 25, 2018
@samdoran
Allow bang and exclamation without warning
f4295c2 
Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.
@samdoran
Use set() rather than braces for Python 2.6
9269198
@samdoran samdoran force-pushed the issue/46334-user-disable-account branch from 34f9648 to 9269198 Compare November 5, 2018 20:55
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 5, 2018
@samdoran samdoran merged commit 066af3b into ansible:devel Nov 5, 2018
@samdoran samdoran deleted the issue/46334-user-disable-account branch November 5, 2018 21:35
samdoran added a commit to samdoran/ansible that referenced this pull request Nov 5, 2018
@samdoran
[stable-2.7] User module - allow bang and exclamation in password fie…
400430e 
…ld without warning (ansible#46498)

* Allow bang and exclamation without warning

Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.

* Use set() rather than braces for Python 2.6
(cherry picked from commit 066af3b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
abadger pushed a commit that referenced this pull request Nov 5, 2018
@samdoran @abadger
[stable-2.7] User module - allow bang and exclamation in password fie…
bab062d 
…ld without warning (#46498)

* Allow bang and exclamation without warning

Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.

* Use set() rather than braces for Python 2.6
(cherry picked from commit 066af3b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@samdoran @mjmayer
User module - allow bang and exclamation in password field without wa…
de0df96 
…rning (ansible#46498)

* Allow bang and exclamation without warning

Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.

* Use set() rather than braces for Python 2.6
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@samdoran @Tomorrow9
User module - allow bang and exclamation in password field without wa…
ccf92cb 
…rning (ansible#46498)

* Allow bang and exclamation without warning

Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.

* Use set() rather than braces for Python 2.6
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user module warn about invalid password when using '*'
2 participants
@samdoran @ansibot