Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ documentation suggests that deleting queues/exchanges is not implemented, but it is #46504

Merged
merged 2 commits into from
Oct 30, 2018
Merged

RabbitMQ documentation suggests that deleting queues/exchanges is not implemented, but it is #46504

merged 2 commits into from
Oct 30, 2018

Conversation

marcjay
Copy link
Contributor

@marcjay marcjay commented Oct 4, 2018

SUMMARY

Documentation for these modules says that state: absent is not implemented for either module, however deletion is in the code and it appears to work correctly

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

rabbitmq_queue
rabbitmq_exchange

ANSIBLE VERSION
ansible 2.4.3.0
  config file = /Users/marcjay/dev/ansible.cfg
  configured module search path = [u'/Users/marcjay/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/marcjay/dev/.venv/lib/python2.7/site-packages/ansible
  executable location = /Users/marcjay/dev/.venv/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Oct 4, 2018

cc @chrishoffman @hyperized @manuel-sousa
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 4, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 4, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 12, 2018
@gundalow gundalow merged commit a24700d into ansible:devel Oct 30, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Oct 30, 2018
@marcjay @gundalow
RabbitMQ documentation suggests that deleting queues/exchanges is not…
98de472 
… implemented, but it is (ansible#46504)

* Remove message suggesting that state: absent is not implemented for queues

* Remove message suggesting that state: absent is not implemented for exchanges

(cherry picked from commit a24700d)
@gundalow gundalow mentioned this pull request Oct 30, 2018
Merged
@gundalow
Copy link
Contributor

@marcjay Thank you very much for this PR, your first I believe.

I've merged this into devel and created a backport for the stable-2.7 branch #47818

acozine pushed a commit that referenced this pull request Oct 30, 2018
@gundalow @acozine
RabbitMQ documentation suggests that deleting queues/exchanges is not…
5c76043 
… implemented, but it is (#46504) (#47818)

* Remove message suggesting that state: absent is not implemented for queues; same for exchanges

(cherry picked from commit a24700d)
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@marcjay @Tomorrow9
RabbitMQ documentation suggests that deleting queues/exchanges is not…
f1193f9 
… implemented, but it is (ansible#46504)

* Remove message suggesting that state: absent is not implemented for queues

* Remove message suggesting that state: absent is not implemented for exchanges
@dagwieers dagwieers added the rabbitmq RabbitMQ community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
@marcjay marcjay deleted the update-rabbitmq-documentation branch August 8, 2020 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. rabbitmq RabbitMQ community small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcjay @ansibot @gundalow @dagwieers @samdoran