Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update set_fact doc to reflect updated caching options #46565

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Update set_fact doc to reflect updated caching options #46565

merged 2 commits into from
Nov 30, 2018

Conversation

Coteh
Copy link
Contributor

@Coteh Coteh commented Oct 6, 2018

SUMMARY

Fixes #31806. I have updated the docs header for the set_fact module to reflect the change it received in version 2.4 to persist variables using the fact cache. (using the cacheable property)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

set_fact

ANSIBLE VERSION

v2.8 (devel branch)

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 6, 2018
@ryansb ryansb removed needs_triage Needs a first human triage before being processed. labels Oct 9, 2018
@bcoca
Copy link
Member

bcoca commented Oct 10, 2018

sadly both the current and updated description are incomplete, the 'cacheable' setting also changes the nature/precedence of the variable to be an actual 'fact'.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 14, 2018
@acozine
Copy link
Contributor

acozine commented Nov 29, 2018

@bcoca is the updated description correct now?

@acozine acozine self-assigned this Nov 29, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 29, 2018
@bcoca
Copy link
Member

bcoca commented Nov 30, 2018

yeah .. just wish it had a loud noise and red sirens

@acozine
Copy link
Contributor

acozine commented Nov 30, 2018

@bcoca I'll add "interactive siren" to the wish list for the docsite . . . meanwhile this is an improvement. Thanks @Coteh for the PR!

@acozine acozine merged commit aee9209 into ansible:devel Nov 30, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@Coteh @kbreit
Update set_fact doc to reflect updated caching options (ansible#46565)
46b9af1 
* Update set_fact doc to reflect updated caching options

* add note about change in precedence caused by caching
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@acozine acozine

Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_fact module docs header needs updated for cacheable
5 participants
@Coteh @bcoca @acozine @ryansb @ansibot