Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape default prompt detection in telnet action plugin #46573

Merged
merged 1 commit into from
Oct 22, 2018
Merged

escape default prompt detection in telnet action plugin #46573

merged 1 commit into from
Oct 22, 2018

Conversation

privateip
Copy link
Contributor

This change fixes an issue with the default prompt handling. The value
needs to be escaped otherwise it does not work when converted to bytes.

escape default prompt detection in telnet action plugin
14ac190 
This change fixes an issue with the default prompt handling.  The value
needs to be escaped otherwise it does not work when converted to bytes.
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 6, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 11, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 14, 2018
@Qalthos Qalthos merged commit 9180d2c into ansible:devel Oct 22, 2018
Qalthos pushed a commit to Qalthos/ansible that referenced this pull request Oct 22, 2018
@privateip @Qalthos
[2.7] escape default prompt detection in telnet action plugin (ansibl…
f8b569b 
…e#46573)

This change fixes an issue with the default prompt handling.  The value
needs to be escaped otherwise it does not work when converted to bytes.
(cherry picked from commit 9180d2c)

Co-authored-by: Peter Sprygada <privateip@users.noreply.github.com>
abadger pushed a commit that referenced this pull request Oct 23, 2018
@Qalthos @abadger
[2.7] escape default prompt detection in telnet action plugin (#46573) (
18f07e8 
#47440)

* [2.7] escape default prompt detection in telnet action plugin (#46573)

This change fixes an issue with the default prompt handling.  The value
needs to be escaped otherwise it does not work when converted to bytes.
(cherry picked from commit 9180d2c)

Co-authored-by: Peter Sprygada <privateip@users.noreply.github.com>

* Add changelog
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@privateip @Tomorrow9
escape default prompt detection in telnet action plugin (ansible#46573)
dac47e9 
This change fixes an issue with the default prompt handling.  The value
needs to be escaped otherwise it does not work when converted to bytes.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@privateip @Qalthos @ansibot @jborean93