Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register missing parameter reboot_timeout #46585

Merged
merged 1 commit into from Oct 8, 2018

Conversation

danieljakots
Copy link
Contributor

SUMMARY

reboot_timeout isn't registered so if one tries using it, ansible will error out.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

reboot

ANSIBLE VERSION
$ ansible --version                                                                                                                       
ansible 2.8.0.dev0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/danj/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/venv/ansible/lib/python2.7/site-packages/ansible
  executable location = /usr/local/venv/ansible/bin/ansible
  python version = 2.7.15 (default, Sep 28 2018, 14:26:01) [GCC 4.2.1 Compatible OpenBSD Clang 6.0.0 (tags/RELEASE_600/final)]
ADDITIONAL INFORMATION

Before my patch (verbosity doesn't change anything in the failure case)

TASK [reboot host] ****************************************************************************************************************************************************************************
fatal: [lama-root]: FAILED! => {"changed": false, "msg": "Invalid options for reboot: reboot_timeout"}

After my patch

TASK [reboot host] ****************************************************************************************************************************************************************************
changed: [lama-root]

What do you think @samdoran?

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 7, 2018
@samdoran
Copy link
Contributor

samdoran commented Oct 8, 2018

Looks good! Please create a changelog fragment. See fragments for examples.

@danieljakots
Copy link
Contributor Author

Indeed I forgot it, thanks for the reminder! Here's one added, I'm not really sure about the wording though. If you have a suggestion feel free to share!

@ansibot ansibot removed small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 8, 2018
@samdoran samdoran merged commit 753711c into ansible:devel Oct 8, 2018
@samdoran
Copy link
Contributor

samdoran commented Oct 8, 2018

Please create a backport PR for this to be included in previous versions.

danieljakots added a commit to danieljakots/ansible that referenced this pull request Oct 8, 2018
@danieljakots
Copy link
Contributor Author

Thanks for the merge!
PR #46651 created :)

@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2018
abadger pushed a commit that referenced this pull request Oct 10, 2018
@danieljakots danieljakots deleted the missing_param branch January 17, 2019 15:41
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants