Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_container: fix problem with published_ports idempotency #46595

Merged
merged 2 commits into from
Oct 8, 2018
Merged

docker_container: fix problem with published_ports idempotency #46595

merged 2 commits into from
Oct 8, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

expected_ports is a dict, not a set (as published_ports).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

ANSIBLE VERSION
2.7.0

@felixfontein felixfontein mentioned this pull request Oct 7, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Oct 7, 2018

cc @chouseknecht @cove @dusdanig @joshuaconner @kassiansun @softzilla @zfil
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 7, 2018
@kassiansun
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Oct 8, 2018
@felixfontein felixfontein force-pushed the docker_container-fix-expected-ports-comparison branch from 5d702a6 to 72e3c46 Compare October 8, 2018 07:27
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Oct 8, 2018
@gundalow gundalow merged commit c5ea3d0 into ansible:devel Oct 8, 2018
@felixfontein
Copy link
Contributor Author

@kassiansun @gundalow Thanks for reviewing and merging!

@felixfontein felixfontein deleted the docker_container-fix-expected-ports-comparison branch October 8, 2018 07:46
felixfontein added a commit to felixfontein/ansible that referenced this pull request Oct 8, 2018
@felixfontein
docker_container: fix problem with published_ports idempotency (ansib…
299f834 
…le#46595)

* Fix comparisons for expected_ports (set vs dict).

* Added changelog.

(cherry picked from commit c5ea3d0)
This was referenced Oct 8, 2018
Merged
Merged
felixfontein added a commit to felixfontein/ansible that referenced this pull request Oct 10, 2018
@felixfontein
docker_container: fix problem with published_ports idempotency (ansib…
fb8bb05 
…le#46595)

* Fix comparisons for expected_ports (set vs dict).

* Added changelog.

(cherry picked from commit c5ea3d0)
@felixfontein felixfontein mentioned this pull request Oct 10, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 11, 2018
@felixfontein @abadger
docker_container: fix problem with published_ports idempotency (#46595)
4ffc75a 
* Fix comparisons for expected_ports (set vs dict).

* Added changelog.

(cherry picked from commit c5ea3d0)
mattclay pushed a commit that referenced this pull request Oct 16, 2018
@felixfontein @mattclay
docker_container: fix problem with published_ports idempotency (#46595)
c41c3b4 
* Fix comparisons for expected_ports (set vs dict).

* Added changelog.

(cherry picked from commit c5ea3d0)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kassiansun kassiansun kassiansun approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. docker module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @kassiansun @gundalow