Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added (Define Values From CSV File) to example section #46620

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Added (Define Values From CSV File) to example section #46620

merged 3 commits into from
Oct 8, 2018

Conversation

colin-mccarthy
Copy link
Contributor

Adding a new example demonstrating setting facts from a CSV file, from a real-world network use case.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@colin-mccarthy
Added (Define Values From CSV File) to example section
1e3aa93 
Adding a new example demonstrating setting facts from a CSV file, from a real-world network use case.
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2018

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/plugins/lookup/csvfile.py:42:1: W293 blank line contains whitespace
lib/ansible/plugins/lookup/csvfile.py:43:36: W291 trailing whitespace
lib/ansible/plugins/lookup/csvfile.py:52:25: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 8, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Oct 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/lookup/csvfile.py:43:36: W291 trailing whitespace

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 8, 2018
@acozine
Copy link
Contributor

acozine commented Oct 8, 2018

Thanks @colin-mccarthy for the example and for your persistence in fixing the whitespace.

@acozine acozine added docs This issue/PR relates to or includes documentation. and removed needs_triage Needs a first human triage before being processed. labels Oct 8, 2018
@acozine acozine merged commit 84a40b7 into ansible:devel Oct 8, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colin-mccarthy @ansibot @acozine