Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmox_kvm: get_vmid fails altogether if any node is offline #46633

Closed
tobiasmcnulty opened this issue Oct 8, 2018 · 4 comments
Closed

proxmox_kvm: get_vmid fails altogether if any node is offline #46633

tobiasmcnulty opened this issue Oct 8, 2018 · 4 comments
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bot_closed bug This issue/PR relates to a bug. cloud collection:community.general collection Related to Ansible Collections work has_pr This issue has an associated PR. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md python3 support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)

Comments

@tobiasmcnulty
Copy link

SUMMARY

If a node is offline, proxmoxer returns a dict describing a VM without a name attribute, like so::

{u'status': u'unknown', u'vmid': 1002, u'type': u'qemu', u'id': u'qemu/1002', u'node': u'pve2'}

This causes get_vmid() to fail since there's no name key in this dict. Worse, this error is hidden and reported as "no such VM in cluster" for any and all VMs, no matter whether they're online or not.

ISSUE TYPE
  • Bug Report
COMPONENT NAME
ANSIBLE VERSION
$ ansible --version
ansible 2.7.0
  config file = None
  configured module search path = ['/Users/tobias/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/tobias/.virtualenvs/proxmox-infra/lib/python3.6/site-packages/ansible
  executable location = /Users/tobias/.virtualenvs/proxmox-infra/bin/ansible
  python version = 3.6.2 (v3.6.2:5fd33b5926, Jul 16 2017, 20:11:06) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]
CONFIGURATION
[blank output]
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 8, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 11, 2018
@Akasurde
Copy link
Member

Akasurde commented Dec 7, 2018

!component =lib/ansible/modules/cloud/misc/proxmox_kvm.py

@dagwieers dagwieers added the virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) label Feb 11, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 3, 2019

@ansibot ansibot added cloud module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 3, 2019
@LaurentDumont
Copy link

What is the status of this. I was just bitten by this when I lost a node on a 4 nodes Proxmox cluster. I knew it was working right before I lost a node so I dig up this issue.

What is required for a Merge?

@ansibot ansibot added the has_pr This issue has an associated PR. label Jul 25, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this as completed Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bot_closed bug This issue/PR relates to a bug. cloud collection:community.general collection Related to Ansible Collections work has_pr This issue has an associated PR. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md python3 support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)
Projects
None yet
Development

No branches or pull requests

6 participants