Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yum module handle list optional empty strings properly #46634

Merged
merged 1 commit into from
Oct 10, 2018
Merged

yum module handle list optional empty strings properly #46634

merged 1 commit into from
Oct 10, 2018

Conversation

maxamillion
Copy link
Contributor

@maxamillion maxamillion commented Oct 8, 2018 •
edited

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

Fixes #46517

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

ANSIBLE VERSION
ansible 2.8.0.dev0 (bugfix/46517-yum-enablerepo-empty-string-list ec423a4653) last updated 2018/10/08 12:31:05 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/admiller/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admiller/src/dev/ansible/lib/ansible
  executable location = /home/admiller/src/dev/ansible/bin/ansible
  python version = 2.7.15 (default, Sep 21 2018, 23:26:48) [GCC 8.1.1 20180712 (Red Hat 8.1.1-5)]

@maxamillion
yum module handle list optional empty strings properly
ec423a4 
Fixes ansible#46517

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion requested a review from bcoca October 8, 2018 19:13
@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2018

@maxamillion: thank you for submitting this pull-request !

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 8, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2018
@maxamillion
Copy link
Contributor Author

rebuild_merge

@maxamillion
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2018

Components

lib/ansible/module_utils/yumdnf.py
support: community
maintainers:

test/integration/targets/yum/tasks/yum.yml
support: core
maintainers: Akasurde ansible berenddeschouwer kustodian maxamillion verm666

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): maxamillion
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot merged commit ad405fc into ansible:devel Oct 10, 2018
@maxamillion maxamillion mentioned this pull request Oct 11, 2018
Merged
maxamillion added a commit to maxamillion/ansible that referenced this pull request Oct 11, 2018
@maxamillion
yum module handle list optional empty strings properly (ansible#46634)
fe29b9c 
Fixes ansible#46517

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit ad405fc)
abadger pushed a commit that referenced this pull request Oct 11, 2018
@maxamillion @abadger
yum module handle list optional empty strings properly (#46634) (#46819)
4fe7671 
* yum module handle list optional empty strings properly (#46634)

Fixes #46517

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit ad405fc)

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@maxamillion @Tomorrow9
yum module handle list optional empty strings properly (ansible#46634)
6e97048 
Fixes ansible#46517

Signed-off-by: Adam Miller <admiller@redhat.com>
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. packaging Packaging category small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'repository not found' if passing empty string to yum 'enablerepo' parameter
5 participants
@maxamillion @ansibot @mkrizek @dagwieers @webknjaz