plugin_filter: check for type error #46664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
Akasurde
removed
the
needs_triage
ansibot
added
needs_revision
ansibot
added
community_review
abadger
reviewed
Oct 26, 2018
abadger
reviewed
Oct 26, 2018
Akasurde
force-pushed
the
i46658
branch
2 times, most recently
from
2cb23c0
to
ebd0785
Compare
ansibot
removed
the
stale_ci
|
Code looks good +1. If you want to backport this, it will need a changelog entry so you might as well add one here before you merge to devel. makes cherry-picking easier. |
* Parsing plugin filter may raise TypeError, gracefully handle this exception and let user know about the syntax error in plugin filter file. * Test for plugin_filtering Fixes: ansible#46658 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
needs_revision
Akasurde
added a commit
to Akasurde/ansible
that referenced
this pull request
Oct 30, 2018
* Parsing plugin filter may raise TypeError, gracefully handle this exception and let user know about the syntax error in plugin filter file. * Test for plugin_filtering Fixes: ansible#46658 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit b32b411)
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
* Parsing plugin filter may raise TypeError, gracefully handle this exception and let user know about the syntax error in plugin filter file. * Test for plugin_filtering Fixes: ansible#46658 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Parsing plugin filter may raise TypeError, gracefully handle this exception
and let user know about the syntax error in plugin filter file.
Fixes: #46658
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/loader.py
ANSIBLE VERSION