Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_storage_domain: Fix error message formating #46678

Merged
merged 1 commit into from
Oct 9, 2018
Merged

ovirt_storage_domain: Fix error message formating #46678

merged 1 commit into from
Oct 9, 2018

Conversation

imjoey
Copy link
Contributor

@imjoey imjoey commented Oct 9, 2018

SUMMARY

The original implementation seems missing the two variables when rendering the error message. Fix it in this pr.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_storage_domain

ANSIBLE VERSION
ansible 2.6.3

@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

@imjoey: thank you for submitting this pull-request!

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 9, 2018
machacekondra
machacekondra approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2018
mwperina
mwperina approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 9, 2018
@ansibot ansibot merged commit 3c7a503 into ansible:devel Oct 9, 2018
@imjoey imjoey deleted the ovirt_fix_string_format branch October 9, 2018 14:11
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@imjoey @ansibot @machacekondra @mwperina @dagwieers