Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovirt_vm] validate memory parameter for ovirt_vm #46698

Merged
merged 1 commit into from
Feb 4, 2019
Merged

[ovirt_vm] validate memory parameter for ovirt_vm #46698

merged 1 commit into from
Feb 4, 2019

Conversation

arielb2
Copy link
Contributor

@arielb2 arielb2 commented Oct 9, 2018

SUMMARY
ISSUE TYPE

#46697

COMPONENT NAME

ovirt_vm

ANSIBLE VERSION
ansible 2.7.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

the suggestion is to validate that the value in the memory clause is always greater than 3, since the minimum value will always be 4

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: Unsupported value(IEC supported): '1GB'
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Unsupported value(IEC supported): '1GB'"}

@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

@arielb2: thank you for submitting this pull-request!

cc @joshainglis @karmab @machacekondra
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) support:community This issue/PR relates to code supported by the Ansible community. traceback This issue/PR includes a traceback. labels Oct 9, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2018
@arielb2 arielb2 force-pushed the fix-ovirt-indexerror branch 2 times, most recently from 48dd80b to 88d5406 Compare October 9, 2018 20:36
@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/ovirt.py:178:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. small_patch labels Oct 9, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 9, 2018
machacekondra
machacekondra approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

mwperina
mwperina approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@machacekondra
Copy link
Contributor

shipit

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 19, 2018
@gundalow gundalow self-assigned this Nov 23, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 23, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 4, 2018
@machacekondra
Copy link
Contributor

shipit

mwperina
mwperina approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@machacekondra
Copy link
Contributor

shipit

mwperina
mwperina approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@mwperina
Copy link
Contributor

mwperina commented Feb 4, 2019

@gundalow Could you please merge it?

@gundalow gundalow added the bug This issue/PR relates to a bug. label Feb 4, 2019
@gundalow gundalow merged commit 57349c0 into ansible:devel Feb 4, 2019
@gundalow
Copy link
Contributor

gundalow commented Feb 4, 2019

Thank you all.
Merged into devel for release in Ansible 2.8

If you'd like this fix in Ansible 2.7 please raise a backport PR including a changelog/fragment file https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy

@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra approved these changes

@mwperina mwperina mwperina approved these changes

Assignees

@gundalow gundalow

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. new_contributor This PR is the first contribution by a new community member. ovirt oVirt and RHV community small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. traceback This issue/PR includes a traceback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@arielb2 @ansibot @machacekondra @mwperina @gundalow @dagwieers @webknjaz