zabbix_hostmacro does not work as expected when used with some LLD trigger prototypes

[HampusLundqvist]

SUMMARY

When using zabbix_hostmacro module, we see there are issues with placing some macros.

ISSUE TYPE

• Bug Report

COMPONENT NAME

zabbix_hostmacro.py

ANSIBLE VERSION

  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/data/home/halu01/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

CONFIGURATION

simple zabbix_hostmacro task

OS / ENVIRONMENT

STEPS TO REPRODUCE

Use LLD Macros according to:
https://www.zabbix.com/documentation/3.4/manual/discovery/low_level_discovery#using_lld_macros_in_user_macro_contexts.
Define a Macro LOW_SPACE_LIMIT in zabbix, and use the following for triggers prototypes:
{$LOW_SPACE_LIMIT:"{#FSNAME}"}

Setting:
Globally ${LOW_SPACE_LIMIT} 20
and try to create a hostmacro for the /home filesystem

zabbix_macros:
- macro_key: "LOW_SPACE_LIMIT:/home"
macro_value: "10"

Macro will be created in zabbix as LOW_SPACE_LIMIT:/HOME

because of:
macro_name = (module.params['macro_name']).upper()

Suggest to replace:
#macro_name = (module.params['macro_name']).upper()
with:
if ":" in module.params['macro_name']:
macro_name = module.params['macro_name'].split(':')[0].upper() + ':' + module.params['macro_name'].split(':')[1]
else:
macro_name = (module.params['macro_name']).upper()

EXPECTED RESULTS

being able to use Macros defined with :MACRO:"/filesystem"

ACTUAL RESULTS

[ansibot]

Hi @HampusLundqvist, thank you for submitting this issue!

click here for bot help

[ansibot]

Files identified in the description:

• lib/ansible/modules/monitoring/zabbix/zabbix_hostmacro.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @D3DeFi @eikef
click here for bot help

[D3DeFi]

@HampusLundqvist thank you for the report and detailed steps to reproduce. I will try to implement fix for it as soon as I am able. Your proposed changes may work, but I need to test them to be sure

[D3DeFi]

@HampusLundqvist would you be interested in submitting this by yourself? Your proposed solution should work fine. Zabbix documentation states that macros use same syntax as trigger expressions, thus it should be safe to split macro_name by colon.

If you don't want to or simply don't have time just let me know and I will submit the fix instead :)