Fix in confirmed_commit capability in netconf_config modules #46964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#46804 * If confirm value is greater than zero or confirm_commit option is set and confirmed-commit capability is not supported but Netconf server only in that case fail the module
|
Hi @ganeshrn, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
mkrizek
removed
the
needs_triage
ansibot
added
support:core
ganeshrn
force-pushed
the
netconf_config_confirm_commit
branch
from
0bc3eaf
to
2c52542
Compare
ansibot
added
owner_pr
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Oct 15, 2018
…#46964) * Fix in confirmed_commit capability in netconf_config modules Fixes ansible#46804 * If confirm value is greater than zero or confirm_commit option is set and confirmed-commit capability is not supported but Netconf server only in that case fail the module * Update confirm-commit flag * Update changelog (cherry picked from commit 5394638)
abadger
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Fix in confirmed_commit capability in netconf_config modules Fixes #46804 * If confirm value is greater than zero or confirm_commit option is set and confirmed-commit capability is not supported but Netconf server only in that case fail the module * Update confirm-commit flag * Update changelog (cherry picked from commit 5394638)
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
…#46964) * Fix in confirmed_commit capability in netconf_config modules Fixes ansible#46804 * If confirm value is greater than zero or confirm_commit option is set and confirmed-commit capability is not supported but Netconf server only in that case fail the module * Update confirm-commit flag * Minor changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #46804
the capability is not supported but Netconf server only in that case fail the module
ISSUE TYPE
COMPONENT NAME
netconf_config
ANSIBLE VERSION
ADDITIONAL INFORMATION