Invalid options for assert: success_msg

[quater]

SUMMARY

With Ansible 2.7, the assert module was enhanced with the success message. See module documentation at https://docs.ansible.com/ansible/2.7/modules/assert_module.html. The below example task fails with the error: Invalid options for assert: success_msg

- name: after version 2.7 both 'msg' and 'fail_msg' can customize failing assertion message
  assert:
    that:
      - "my_param <= 100"
      - "my_param >= 0"
    fail_msg: "'my_param' must be between 0 and 100"
    success_msg: "'my_param' is between 0 and 100"

ISSUE TYPE

• Bug Report

COMPONENT NAME

assert

ANSIBLE VERSION

ansible 2.7.0

STEPS TO REPRODUCE

- name: after version 2.7 both 'msg' and 'fail_msg' can customize failing assertion message
  assert:
    that:
      - "my_param <= 100"
      - "my_param >= 0"
    fail_msg: "'my_param' must be between 0 and 100"
    success_msg: "'my_param' is between 0 and 100"

EXPECTED RESULTS

It should accept the success_msg parameter

ACTUAL RESULTS

fatal: [hostname]: FAILED! => changed=false 
  msg: 'Invalid options for assert: success_msg'

[ansibot]

Hi @quater, thank you for submitting this pull-request!

click here for bot help

[Akasurde]

@quater Thanks for the pull request. Could you please use devel as base branch, as there are some merge conflicts which caused CI failures ? Once this is merged in devel we can create backport of this change to other branches such as Stable-2.7 and Stable-2.6 (as applicable).

[Akasurde]

CI failure - https://app.shippable.com/github/ansible/ansible/runs/88422/1/console

[quater]

@Akasurde Initially I had this PR pointing to the Stable-2.7 branch but I then changed it to the devel base branch within 20 minutes of having created this PR. It appears that this didn't trigger a new CI test run. Can you trigger a test manually please?

[Akasurde]

@quater I see merge conflict errors in https://app.shippable.com/github/ansible/ansible/runs/88515/1/console, I think you need to create PR with devel as base branch rather than stable-2.7.

[quater]

@Akasurde I corrected it now. It should be good to go.

[Akasurde]

LGTM, need another pair of eye to take a look.