Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for clearlinux showing release number #47101

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Adding support for clearlinux showing release number #47101

merged 1 commit into from
Nov 23, 2018

Conversation

josuedhg
Copy link
Contributor

@josuedhg josuedhg commented Oct 16, 2018 •
edited by gundalow

Signed-off-by: Josue David Hernandez josue.d.hernandez.gutierrez@intel.com

SUMMARY

variable ansible_distribution_version shows NA and must show the release number

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ANSIBLE VERSION

ansible 2.8.0.dev0
ADDITIONAL INFORMATION

@josuedhg
Adding support for clearlinux showing release nuber
3ab2442 
Signed-off-by: Josue David Hernandez <josue.d.hernandez.gutierrez@intel.com>
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

Hi @josuedhg, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 16, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 26, 2018
@josuedhg
Copy link
Contributor Author

any update?

@gundalow gundalow changed the title Adding support for clearlinux showing release nuber Adding support for clearlinux showing release number Nov 23, 2018
@gundalow gundalow merged commit 8880c72 into ansible:devel Nov 23, 2018
@gundalow
Copy link
Contributor

@josuedhg Thank you for this. Merged into devel for release in Ansible 2.8

If there are any other clearlinux fixes feel free to @gundalow in the PR and I'll look at getting them merged

mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@josuedhg @mjmayer
Adding support for clearlinux showing release nuber (ansible#47101)
60d5ec3 
Signed-off-by: Josue David Hernandez <josue.d.hernandez.gutierrez@intel.com>
@josuedhg
Copy link
Contributor Author

josuedhg commented Dec 5, 2018

@gundalow I will create a backport to 2.7 for this

@josuedhg
Copy link
Contributor Author

josuedhg commented Dec 5, 2018

backported in #49571

abadger pushed a commit that referenced this pull request Dec 6, 2018
@josuedhg @abadger
Adding support for clearlinux showing release nuber (#47101)
35e0229 
Signed-off-by: Josue David Hernandez <josue.d.hernandez.gutierrez@intel.com>
(cherry picked from commit 8880c72)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josuedhg @ansibot @gundalow @jborean93