yum/dnf: fail when space separated string of names #47109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mkrizek, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
mkrizek
commented
Oct 16, 2018
lib/ansible/module_utils/yumdnf.py
Outdated
| @@ -98,6 +98,15 @@ def __init__(self, module): | |||
| self.enablerepo = self.listify_comma_sep_strings_in_list(self.enablerepo) | |||
| self.exclude = self.listify_comma_sep_strings_in_list(self.exclude) | |||
|
|
|||
| # Fail if someone passed a space separated string | |||
| # https://github.com/ansible/ansible/issues/46301 | |||
| if any((' ' in name for name in self.names)): | |||
There was a problem hiding this comment.
Hrm, so my assumption "who would put space in a package name?" wasn't true of course. This breaks @Development Tools use case.
There was a problem hiding this comment.
Right, so a rpm package name can not contain a space, but groups can. I guess you can just add a and '@' not in name to your conditional and that should handle it.
|
CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/88652/35/tests |
mattclay
added
the
ci_verified
ansibot
removed
the
needs_triage
ansibot
added
core_review
|
rebuild_merge |
|
@mkrizek I think this should be backported to |
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Oct 22, 2018
* yum/dnf: fail when space separated string of names * Groups allow spaces in names (cherry picked from commit e8b6864)
|
@maxamillion Created #47414. |
abadger
pushed a commit
that referenced
this pull request
Oct 22, 2018
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
* yum/dnf: fail when space separated string of names * Groups allow spaces in names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
@maxamillion I wonder if the failure is too much but the docs clarification is worth adding I think.
Related to #46301
ISSUE TYPE
COMPONENT NAME
yum
dnf
ANSIBLE VERSION
ADDITIONAL INFORMATION