Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_vm: Add option to export the VMs. #47113

Merged
merged 1 commit into from
Oct 19, 2018
Merged

ovirt_vm: Add option to export the VMs. #47113

merged 1 commit into from
Oct 19, 2018

Conversation

nijinashok
Copy link
Contributor

SUMMARY

The commit adds the feature to export the VM to export domain and also as OVA to a specific directory in the host. 

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ovirt_vm

ANSIBLE VERSION
ansible --version
ansible 2.7.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Aug  2 2016, 04:20:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

Hi @nijinashok, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) support:community This issue/PR relates to code supported by the Ansible community. labels Oct 16, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
machacekondra
machacekondra reviewed Oct 18, 2018
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good.

lib/ansible/modules/cloud/ovirt/ovirt_vm.py Outdated Show resolved Hide resolved
@nijinashok
ovirt_vm: Add option to export the VMs
ae436a9 
The commit adds the feature to export the VM to export domain and as
OVA.
@nijinashok
Copy link
Contributor Author

Thank you @machacekondra for reviewing. I have changed as per your suggestions.

machacekondra
machacekondra approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

mwperina
mwperina approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 19, 2018
@ansibot ansibot merged commit 29c76c5 into ansible:devel Oct 19, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@nijinashok @Tomorrow9
ovirt_vm: Add option to export the VMs (ansible#47113)
e6760fb 
The commit adds the feature to export the VM to export domain and as
OVA.
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nijinashok @ansibot @machacekondra @mwperina @dagwieers @jborean93