Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows example of raw command #47153

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Add Windows example of raw command #47153

merged 4 commits into from
Nov 30, 2018

Conversation

jvandermeulen
Copy link
Contributor

Perform shutdown of Windows OS using Microsoft.PowerShell.Management module

SUMMARY

Add first example for Windows boxes

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@jvandermeulen
Add Windows example of raw command
c784142 
Perform shutdown of Windows OS using Microsoft.PowerShell.Management module
@jborean93
Copy link
Contributor

This isn't something we want as shutting down a host can lead to other issues with Ansible. Happy to show another PowerShell example but not one that shutdowns the server.

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @jvandermeulen, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 17, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 25, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 26, 2018
@dagwieers
Capitalized cmdlet, remove quotes and improve description
e3cb953 
This commit also cleans up some of the description sections.
dagwieers
dagwieers approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It is good to have a Windows example, and Stop-Computer is a useful example at that. I slightly modified the example and did some more cleanup to the docs.

@dagwieers
Use another example as suggested by jborean93
362c1c8 
I was happy to merge this before I noticed jborean93 objected to the example :-/
@dagwieers
Copy link
Contributor

@jvandermeulen Since @jborean93 objects to the example, I replaced it with an invocation of Get-WmiObject -Class Win32_UserAccount.

Although something like that would work as well with the win_shell module.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 29, 2018
@jvandermeulen
Copy link
Contributor Author

@dagwieers Excellent idea!

@dagwieers dagwieers merged commit 8ff13db into ansible:devel Nov 30, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jvandermeulen @kbreit
Add Windows example of raw command (ansible#47153)
651fb0d 
* Add Windows example of raw command

Perform shutdown of Windows OS using Microsoft.PowerShell.Management module

* Capitalized cmdlet, remove quotes and improve description

This commit also cleans up some of the description sections.

* Use another example as suggested by jborean93

I was happy to merge this before I noticed jborean93 objected to the example :-/

* Fix whitespace issue
@dagwieers dagwieers added the windows Windows community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jvandermeulen @jborean93 @ansibot @dagwieers