Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto scale create with fix date without recurrence #47186

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Fix auto scale create with fix date without recurrence #47186

merged 2 commits into from
Oct 18, 2018

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Oct 17, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_autoscale

ANSIBLE VERSION
2.7.0
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @yuwzho, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @zikalino
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 17, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Oct 18, 2018
Closed
@zikalino
Copy link
Contributor

a kind of difficult to understand what the bug was exactly

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@yuwzho
Copy link
Contributor Author

yuwzho commented Oct 18, 2018

@zikalino When using this module to create an auto scale setting with a fixed date, the code construct the setting instance without recurrence, So here need to check whether the recurrence is none, if so, the code needs to set the recurrence in the autoscalesettings to None.

@zikalino zikalino merged commit 9258ffa into ansible:devel Oct 18, 2018
@zikalino zikalino deleted the yuwzho--autoscale branch October 18, 2018 02:52
yuwzho added a commit to VSChina/ansible that referenced this pull request Oct 18, 2018
@yuwzho
Fix auto scale create with fix date without recurrence (ansible#47186)
30add2d 
* Fix auto scale create with fix date without  recurrence

* fix indent

(cherry picked from commit 9258ffa)
abadger pushed a commit that referenced this pull request Oct 23, 2018
@yuwzho @abadger
Fix auto scale create with fix date without recurrence (#47186) (#47258)
ab1834f 
* Fix auto scale create with fix date without  recurrence (#47186)

* Fix auto scale create with fix date without  recurrence

* fix indent

(cherry picked from commit 9258ffa)

* Create azure_rm_autoscale-fixed_date.yml changelog
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@yuwzho @Tomorrow9
Fix auto scale create with fix date without recurrence (ansible#47186)
90af03b 
* Fix auto scale create with fix date without  recurrence

* fix indent
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zikalino zikalino zikalino approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuwzho @ansibot @zikalino