Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt: add policy_rc_d option #47191

Merged
merged 1 commit into from
Nov 19, 2018
Merged

apt: add policy_rc_d option #47191

merged 1 commit into from
Nov 19, 2018

Conversation

tchernomax
Copy link
Contributor

SUMMARY

Add policy_rc_d option to apt module.

In order to prevent a service start at package installation, it is a common practice to change the /usr/policy-rc.d file (to exit 101):
https://people.debian.org/~hmh/invokerc.d-policyrc.d-specification.txt

This policy_rc_d option allow the user the temporarily force the /usr/policy-rc.d to exit with a specified code. Allowing the user, for example, to temporarily forbid the dpkg triggered service start.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

apt

ANSIBLE VERSION
ansible 2.8.0.dev0 (apt 365d81d779) last updated 2018/10/17 13:37:47 (GMT +200)
  config file = /home/max/.ansible.cfg
  configured module search path = ['/home/max/.ansible/modules']
  ansible python module location = /home/max/Documents/repositories-github/ansible/lib/ansible
  executable location = /home/max/Documents/repositories-github/ansible/bin/ansible
  python version = 3.7.0 (default, Sep 15 2018, 19:13:07) [GCC 8.2.1 20180831]
ADDITIONAL INFORMATION

It make the pull request #32856 obsolete.

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @tchernomax, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

cc @mgwilliams
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 17, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
kobbs
kobbs approved these changes Oct 18, 2018
View reviewed changes
Copy link

@kobbs kobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

limhud
limhud approved these changes Oct 18, 2018
View reviewed changes
Copy link

@limhud limhud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

xorilog
xorilog approved these changes Oct 22, 2018
View reviewed changes
Copy link

@xorilog xorilog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 30, 2018
angristan
angristan approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 19, 2018
@gundalow gundalow merged commit 943edb3 into ansible:devel Nov 19, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@tchernomax @mjmayer
apt: add policy_rc_d option (ansible#47191)
f8b9554
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@tchernomax @Tomorrow9
apt: add policy_rc_d option (ansible#47191)
cc29642
@tchernomax tchernomax mentioned this pull request Jan 26, 2019
Closed
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
@tchernomax tchernomax deleted the apt branch August 24, 2019 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xorilog xorilog xorilog approved these changes

@angristan angristan angristan approved these changes

@kobbs kobbs kobbs approved these changes

@limhud limhud limhud approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. packaging Packaging category shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tchernomax @ansibot @xorilog @angristan @kobbs @limhud @dagwieers @gundalow @jborean93