New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reboot: Add timeout in error to help troubleshooting #47216
Conversation
So we've been hit by 'Timed out waiting for boot_time check' and it was unclear what timeout was used for the boot_time check. By adding the timeout value it is easier to understand the used value, and verify if a change to the timeout is reflected in the output.
It would also be nice if every |
Hi @dagwieers, thank you for submitting this pull-request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add a changelog fragment please?
Is this timeout indicating a problem in the plugin, or does the system just need more time to come back up? |
Let me explain, for Windows servers we moved to starting the WinRM service delayed, for the reason that the system was not settled when the WinRM service became available. For some tasks this means unreliability, as basic functionality may or may not have been available. A delayed restart of WinRM means that the boot_time check may be delayed by a few minutes (depending on the services the system is starting, e.g. AD or SCVMM) and in this case we're talking about a physical machine which has notorious BIOS checks and boot times. So 10 minutes (which includes a physical server reboot plus Windows services until it has settled) may not be sufficient. What's more on Windows we have another issue which is that during reboot (pre and post boot) updates could have actions scheduled that prolong the boot time as well. Which may make win_reboot a very unreliable task :-( We decided in the Windows WG meeting yesterday that we need to add some explicit information regarding this to warn the user. (As there's no means to know whether this will be the case in the upcoming boot). |
Changelog fragment is added. |
Ok, thanks for the detailed info. |
* reboot: Add timeout in error to help troubleshooting So we've been hit by 'Timed out waiting for boot_time check' and it was unclear what timeout was used for the boot_time check. By adding the timeout value it is easier to understand the used value, and verify if a change to the timeout is reflected in the output. * Add changelog fragment
SUMMARY
So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.
ISSUE TYPE
COMPONENT NAME
reboot, win_reboot
ANSIBLE VERSION
v2.8