Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reboot: Add timeout in error to help troubleshooting #47216

Merged
merged 2 commits into from Oct 18, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Oct 17, 2018

SUMMARY

So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

reboot, win_reboot

ANSIBLE VERSION

v2.8

So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.
@dagwieers
Copy link
Contributor Author

It would also be nice if every fail_json() call would return how much time in total elapsed. But that's not so easy to do currently. Needs another PR.

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @dagwieers, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 17, 2018
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a changelog fragment please?

@samdoran
Copy link
Contributor

Is this timeout indicating a problem in the plugin, or does the system just need more time to come back up?

@dagwieers
Copy link
Contributor Author

dagwieers commented Oct 17, 2018

Let me explain, for Windows servers we moved to starting the WinRM service delayed, for the reason that the system was not settled when the WinRM service became available. For some tasks this means unreliability, as basic functionality may or may not have been available.

A delayed restart of WinRM means that the boot_time check may be delayed by a few minutes (depending on the services the system is starting, e.g. AD or SCVMM) and in this case we're talking about a physical machine which has notorious BIOS checks and boot times.

So 10 minutes (which includes a physical server reboot plus Windows services until it has settled) may not be sufficient. What's more on Windows we have another issue which is that during reboot (pre and post boot) updates could have actions scheduled that prolong the boot time as well. Which may make win_reboot a very unreliable task :-(

We decided in the Windows WG meeting yesterday that we need to add some explicit information regarding this to warn the user. (As there's no means to know whether this will be the case in the upcoming boot).

@dagwieers
Copy link
Contributor Author

Changelog fragment is added.

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@samdoran
Copy link
Contributor

Ok, thanks for the detailed info.

@samdoran samdoran merged commit 06eabc9 into ansible:devel Oct 18, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
* reboot: Add timeout in error to help troubleshooting

So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.

* Add changelog fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants