Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_url: Updates documentation for proper use of headers #47242

Merged
merged 3 commits into from
Oct 18, 2018
Merged

get_url: Updates documentation for proper use of headers #47242

merged 3 commits into from
Oct 18, 2018

Conversation

borener
Copy link
Contributor

@borener borener commented Oct 17, 2018

SUMMARY

Went to remove the deprecation warning for headers we were receiving after the upgrade to 2.7. The proper syntax to accomplish the task was not in the examples. Removed outdated example and replaced with updated format.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

get_url

ANSIBLE VERSION
ansible 2.7.0
  config file = /cyclops-ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15 (default, Aug 22 2018, 13:28:29) [GCC 6.3.0]
ADDITIONAL INFORMATION

N/A

fxfitz
fxfitz approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@fxfitz fxfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sivel
Copy link
Member

sivel commented Oct 17, 2018

There appear to be trailing spaces on line 183 and 184. Once those are removed and CI is green, I'll get this merged.

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @borener, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/net_tools/basics/get_url.py:183:13: W291 trailing whitespace
lib/ansible/modules/net_tools/basics/get_url.py:184:16: W291 trailing whitespace

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

cc @jpmens @ptux
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 17, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 17, 2018
@borener
Copy link
Contributor Author

borener commented Oct 17, 2018

Fixed. Thanks Sivel!

@ptux ptux mentioned this pull request Oct 18, 2018
Closed
@sivel sivel merged commit 3b5471a into ansible:devel Oct 18, 2018
sivel pushed a commit to sivel/ansible that referenced this pull request Oct 18, 2018
@borener @sivel
[stable-2.7] get_url: Updates documentation for proper use of headers (…
d9d9a27 
…ansible#47242)

* Fixes the example for headers in documentation

* remove whitespace

* missed a whitespace
(cherry picked from commit 3b5471a)

Co-authored-by: Nate Borener <33846287+borener@users.noreply.github.com>
abadger pushed a commit that referenced this pull request Oct 22, 2018
@borener @abadger
[stable-2.7] get_url: Updates documentation for proper use of headers (…
ee45520 
…#47242)

* Fixes the example for headers in documentation

* remove whitespace

* missed a whitespace
(cherry picked from commit 3b5471a)

Co-authored-by: Nate Borener <33846287+borener@users.noreply.github.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@borener @Tomorrow9
get_url: Updates documentation for proper use of headers (ansible#47242)
bb77595 
* Fixes the example for headers in documentation

* remove whitespace

* missed a whitespace
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

@fxfitz fxfitz fxfitz approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@borener @sivel @ansibot @fxfitz