Don't use the task for a cache, return a special cache var #47243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoca
reviewed
Oct 17, 2018
| if loop_cache is not None: | ||
| # _ansible_loop_cache may be set in `get_vars` when calculating `delegate_to` | ||
| # to avoid reprocessing the loop | ||
| items = copy.copy(loop_cache) |
There was a problem hiding this comment.
wouldn't we need a deepcopy here?
There was a problem hiding this comment.
Oh, actually, I can remove that all together. I had added it when I was removing it from _job_vars.
|
Hi @sivel, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
jborean93
removed
the
needs_triage
jimi-c
approved these changes
Oct 18, 2018
bcoca
approved these changes
Oct 18, 2018
ansibot
added
core_review
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Oct 18, 2018
…ar (ansible#47243) * Don't use task to cache loop results, use hostvars. Fixes ansible#47207 * Avoid a race condition, supply _ansible_loop_cache through get_vars directly * Add tests * Add changelog fragment * Remove unnecessary copy * Remove unnecessary host from _get_delegated_vars signature. (cherry picked from commit 77d32b8) Co-authored-by: Matt Martz <matt@sivel.net>
abadger
pushed a commit
that referenced
this pull request
Oct 22, 2018
…ar (#47243) * Don't use task to cache loop results, use hostvars. Fixes #47207 * Avoid a race condition, supply _ansible_loop_cache through get_vars directly * Add tests * Add changelog fragment * Remove unnecessary copy * Remove unnecessary host from _get_delegated_vars signature. (cherry picked from commit 77d32b8) Co-authored-by: Matt Martz <matt@sivel.net>
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
…7243) * Don't use task to cache loop results, use hostvars. Fixes ansible#47207 * Avoid a race condition, supply _ansible_loop_cache through get_vars directly * Add tests * Add changelog fragment * Remove unnecessary copy * Remove unnecessary host from _get_delegated_vars signature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR addresses an issue where looping over a hostvar, with a templated
delegate_towould create a loop cache on the task for the last host in the loop. Fixes #47207The original problem that was being solved was the following:
Because we process the loop in
VariableManager._get_delegated_varsand inTaskExecutor._get_loop_itemsthat loop could produce different results, causingansible_delegated_varsto not exist for the host later selected inTaskExecutor._get_loop_itemsWe solved that by caching the resultant loop as
task.loop. The problem with that is when the variable being looped is different per host.This fix allows the original case to work, as well as the case of:
ISSUE TYPE
COMPONENT NAME
lib/ansible/executor/task_executor.py
lib/ansible/vars/manager.py
ANSIBLE VERSION
ADDITIONAL INFORMATION
Also, not mentioned above is that an inventory was supplied to some other tests that were skipping as a result of the inventory not matching.