Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pamd: add delete=False to NamedTemporaryFile() #47281

Merged
merged 2 commits into from
Oct 19, 2018
Merged

pamd: add delete=False to NamedTemporaryFile() #47281

merged 2 commits into from
Oct 19, 2018

Conversation

shepdelacreme
Copy link
Contributor

SUMMARY

Need to set delete=False on NamedTemporaryFile() or the file will be deleted after its closed which causes an issue. Fixes #47080

Also removes errant print statement in the module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pamd

ANSIBLE VERSION
ansible 2.8.0.dev0 (pamd_47080_fix c6c5d072ed) last updated 2018/10/18 08:18:34 (GMT -400)
  config file = /Users/me/.ansible.cfg
  configured module search path = ['/Users/me/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/me/devel/shep-ansible/lib/ansible
  executable location = /Users/me/devel/shep-ansible/bin/ansible
  python version = 3.6.6 (default, Jul 21 2018, 22:49:24) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

Hi @shepdelacreme, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 18, 2018
@samdoran
Copy link
Contributor

Please create a changelog fragment. See fragments for examples.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@shepdelacreme
Copy link
Contributor Author

Add fragment, let me know if I did that right.

@samdoran samdoran merged commit c67ab29 into ansible:devel Oct 19, 2018
@samdoran
Copy link
Contributor

Looks good! Please create a backport PR for this to be included in previous versions.

@shepdelacreme shepdelacreme mentioned this pull request Oct 22, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 23, 2018
@shepdelacreme @abadger
pamd: add delete=False to NamedTemporaryFile() (#47281)
1a46043 
* add delete=False to NamedTemporaryFile and remove print statement from module

* add changelog fragment

* use module.tmpdir from (#47133) and add changelog fragment for it as well

(cherry picked from commit c67ab29)
@shepdelacreme shepdelacreme deleted the pamd_47080_fix branch October 23, 2018 13:15
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@shepdelacreme @Tomorrow9
pamd: add delete=False to NamedTemporaryFile() (ansible#47281)
a819059 
* add delete=False to NamedTemporaryFile and remove print statement from module

* add changelog fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pamd Exception OSError attempting to close already removed temporary file
3 participants
@shepdelacreme @ansibot @samdoran