Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios check_rc: Default to sending text of exception, not the whole exception #47300

Merged
merged 2 commits into from
Oct 24, 2018
Merged

ios check_rc: Default to sending text of exception, not the whole exception #47300

merged 2 commits into from
Oct 24, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Oct 18, 2018

SUMMARY

Fixes #46976

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios

ANSIBLE VERSION
2.8

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

Hi @Qalthos, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

cc @NilashishC @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 18, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@Qalthos Qalthos mentioned this pull request Oct 23, 2018
Closed
@Qalthos Qalthos merged commit 6a866a5 into ansible:devel Oct 24, 2018
@Qalthos Qalthos deleted the ios-fix-check-rc branch October 24, 2018 13:56
Qalthos added a commit to Qalthos/ansible that referenced this pull request Oct 24, 2018
@Qalthos
[2.7] ios check_rc: Default to sending text of exception, not the who…
922dece 
…le exception (ansible#47300)

* Default to sending text of exception, not the whole exception
(cherry picked from commit 6a866a5)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
abadger pushed a commit that referenced this pull request Oct 25, 2018
@Qalthos @abadger
[2.7] ios check_rc: Default to sending text of exception, not the who…
ffe80a1 
…le exception (#47300)

* Default to sending text of exception, not the whole exception
(cherry picked from commit 6a866a5)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@Qalthos @Tomorrow9
ios check_rc: Default to sending text of exception, not the whole exc…
f9cb129 
…eption (ansible#47300)

* Default to sending text of exception, not the whole exception
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

@justjais justjais Awaiting requested review from justjais

@NilashishC NilashishC Awaiting requested review from NilashishC

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. ios Cisco IOS community networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible 2.7 ios_facts no longer working
4 participants
@Qalthos @ansibot @dagwieers @mkrizek