Fix exception when including tasks from handlers

[pablorf-dev]

SUMMARY

Set _notified_handlers for the task's _uuid that is run as a handler

Fix #47287

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

include_task, handlers

ANSIBLE VERSION

ansible 2.8.0.dev0 (devel 3feb6c9e0f) last updated 2018/10/18 18:36:50 (GMT +200)

ADDITIONAL INFORMATION

Before this patch:

$ ansible-playbook -i 127.0.0.1, -c local -Dvv playbook.yml
ansible-playbook 2.8.0.dev0 (devel 3feb6c9e0f) last updated 2018/10/18 18:36:50 (GMT +200)
  config file = None
  configured module search path = [u'/home/pablorf/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/pablorf/dev/ansible/lib/ansible
  executable location = /home/pablorf/dev/ansible/bin/ansible-playbook
  python version = 2.7.13 (default, Sep 26 2018, 18:42:22) [GCC 6.3.0 20170516]
No config file found; using defaults

PLAYBOOK: playbook.yml ********************************************************************************************************
1 plays in playbook.yml

PLAY [localhost] **************************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:2
ok: [127.0.0.1]
META: ran handlers

TASK [include a task from the tasks section] **********************************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:4
included: /home/pablorf/dev/ansible/include.yml for 127.0.0.1

TASK [an included task] *******************************************************************************************************
task path: /home/pablorf/dev/ansible/include.yml:2
ok: [127.0.0.1] => {
    "msg": "foo"
}

TASK [notify a handler] *******************************************************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:7
NOTIFIED HANDLER include a task from the handlers section for 127.0.0.1
changed: [127.0.0.1] => {
    "msg": "bar"
}

RUNNING HANDLER [include a task from the handlers section] ********************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:14
included: /home/pablorf/dev/ansible/include.yml for 127.0.0.1

RUNNING HANDLER [an included task] ********************************************************************************************
task path: /home/pablorf/dev/ansible/include.yml:2
ok: [127.0.0.1] => {
    "msg": "foo"
}
ERROR! Unexpected Exception, this is probably a bug: '7085c267-13ea-d9bc-987c-000000000031'
to see the full traceback, use -vvv

After this patch:

$ ansible-playbook -i 127.0.0.1, -c local -Dvv playbook.yml
ansible-playbook 2.8.0.dev0 (fix_included_task_in_handler 36b8849f8f) last updated 2018/10/18 21:06:57 (GMT +200)
  config file = None
  configured module search path = [u'/home/pablorf/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/pablorf/dev/ansible/lib/ansible
  executable location = /home/pablorf/dev/ansible/bin/ansible-playbook
  python version = 2.7.13 (default, Sep 26 2018, 18:42:22) [GCC 6.3.0 20170516]
No config file found; using defaults

PLAYBOOK: playbook.yml ********************************************************************************************************
1 plays in playbook.yml

PLAY [localhost] **************************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:2
ok: [127.0.0.1]
META: ran handlers

TASK [include a task from the tasks section] **********************************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:4
included: /home/pablorf/dev/ansible/include.yml for 127.0.0.1

TASK [an included task] *******************************************************************************************************
task path: /home/pablorf/dev/ansible/include.yml:2
ok: [127.0.0.1] => {
    "msg": "foo"
}

TASK [notify a handler] *******************************************************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:7
NOTIFIED HANDLER include a task from the handlers section for 127.0.0.1
changed: [127.0.0.1] => {
    "msg": "bar"
}

RUNNING HANDLER [include a task from the handlers section] ********************************************************************
task path: /home/pablorf/dev/ansible/playbook.yml:14
included: /home/pablorf/dev/ansible/include.yml for 127.0.0.1

RUNNING HANDLER [an included task] ********************************************************************************************
task path: /home/pablorf/dev/ansible/include.yml:2
ok: [127.0.0.1] => {
    "msg": "foo"
}
META: ran handlers
META: ran handlers

PLAY RECAP ********************************************************************************************************************
127.0.0.1                  : ok=6    changed=1    unreachable=0    failed=0    skipped=0

[sivel]

Please include a new integration test that ensures we don't regress in the future.

Also include a changelog/fragments for this change too.

[ansibot]

Hi @pablorf-dev, thank you for submitting this pull-request!

click here for bot help