Add to k8s_raw docs re: vault-encrypted files #47328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't read the examples far enough and maybe would not have tried all the examples so I ended up creating ansible#47259 and learned that definition key with lookup works well and we agreed the docs should say something. :) +label: docsite_pr
|
Hi @r4j4h, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
|
Thanks for doing this - this is good, I think it could be improved further by mentioning in the description of |
ansibot
removed
the
needs_triage
|
I would love to, but I can't seem to find where the description of |
|
Of course after I post I think of a more clever way to find it. How does that look? Felt wrong to mash it with the controller file description since only the lookup is needed so I added that as another bullet point instead. |
ansibot
added
core_review
dagwieers
added
the
docsite_pr
fabianvf
suggested changes
Oct 25, 2018
fabianvf
approved these changes
Oct 25, 2018
willthames
suggested changes
Oct 25, 2018
lib/ansible/utils/module_docs_fragments/k8s_resource_options.py
Outdated
Show resolved
Hide resolved
ansibot
added
needs_revision
|
@willthames @fabianvf Great feedback, I will make the suggested changes soon :) |
|
Thanks @r4j4h for making the docs better! |
|
It was truly my pleasure @willthames :) I'm glad I could help and hope to more in time. 💖 |
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
* Add to k8s_raw docs re: vault-encrypted files I didn't read the examples far enough and maybe would not have tried all the examples so I ended up creating ansible#47259 and learned that definition key with lookup works well and we agreed the docs should say something. :) +label: docsite_pr * Add note about ansible vault-encrypted files to src: param * Remove trailing whitespace * Make changes from feedback * Make feedback changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't read the examples far enough and maybe would not have tried all the examples so I ended up creating #47259 and learned that definition key with lookup works well and we agreed the docs should say something. :)
+label: docsite_pr
SUMMARY
Fixes #47259
ISSUE TYPE
COMPONENT NAME
k8s_raw
ANSIBLE VERSION
ADDITIONAL INFORMATION