Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module portinstall: use_packages is a bool #47370

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Module portinstall: use_packages is a bool #47370

merged 1 commit into from
Oct 26, 2018

Conversation

overhacked
Copy link
Contributor

SUMMARY

The portinstall module checks if use_packages == "yes", but AnsibleModule actually converts the use_packages argument to a bool.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

portinstall

ANSIBLE VERSION
ansible 2.6.4
  config file = None
  configured module search path = ['/Users/overhack/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ansible
  executable location = /opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin/ansible
  python version = 3.6.6 (default, Jun 28 2018, 05:43:53) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]
ADDITIONAL INFORMATION

There's no change in Ansible command output, but the portinstall module fails to add the --use-packages option to the portinstall command line, causing every package/port specified (and all its dependencies) to be built from source. After this change, the option is correctly added to the command line.

@overhacked
Module portinstall: use_packages is a bool
f46d183 
The module has been checking if use_packages is
a string equal to "yes", but AnsibleModule actually
converts the use_packages argument to a bool.
@ansibot
Copy link
Contributor

ansibot commented Oct 19, 2018

Hi @overhacked, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 19, 2018
@jborean93 jborean93 merged commit 300db3a into ansible:devel Oct 26, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 26, 2018
@overhacked overhacked deleted the module-portinstall-use_packages_bool branch November 7, 2018 15:12
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@overhacked @Tomorrow9
Module portinstall: use_packages is a bool (ansible#47370)
3644af3 
The module has been checking if use_packages is
a string equal to "yes", but AnsibleModule actually
converts the use_packages argument to a bool.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@overhacked @ansibot @jborean93