Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubeconfig if either context or kubeconfig is set #47373

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Use kubeconfig if either context or kubeconfig is set #47373

merged 1 commit into from
Oct 23, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

kubeconfig should be loaded if either or both of context
or kubeconfig is set (this allows picking a context and default
kubeconfig or picking a kubeconfig with default context)

Fixes #47149

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

ANSIBLE VERSION
ansible 2.8.0.dev0 (devel acda7bae5f) last updated 2018/10/20 12:58:54 (GMT +1000)
  config file = None
  configured module search path = [u'/Users/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/will/src/ansible/lib/ansible
  executable location = /Users/will/src/ansible/bin/ansible
  python version = 2.7.15 (default, Oct  2 2018, 11:47:18) [GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.11.45.2)]
ADDITIONAL INFORMATION

Should be backported to 2.7

@willthames
Use kubeconfig if either context or kubeconfig is set
b726fe1 
kubeconfig should be loaded if *either* or both of context
or kubeconfig is set (this allows picking a context and default
kubeconfig or picking a kubeconfig with default context)

Fixes ansible#47149
@willthames willthames mentioned this pull request Oct 20, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Oct 20, 2018

Hi @willthames, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 20, 2018

cc @chouseknecht @fabianvf @flaper87 @maxamillion
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. k8s needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 20, 2018
@fabianvf
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 20, 2018
@gundalow gundalow merged commit 00ccad9 into ansible:devel Oct 23, 2018
@gundalow
Copy link
Contributor

Thanks for the PR and reviews. Merged into devel, please raise a backport PR if you would like this fix in 2.7 or earlier..

willthames added a commit to willthames/ansible that referenced this pull request Oct 23, 2018
@willthames
Use kubeconfig if either context or kubeconfig is set (ansible#47373)
c2f1df7 
kubeconfig should be loaded if *either* or both of context
or kubeconfig is set (this allows picking a context and default
kubeconfig or picking a kubeconfig with default context)

Fixes ansible#47149

(cherry picked from commit 00ccad9)
@willthames
Copy link
Contributor Author

Thanks @gundalow. Backport for 2.7 raised at #47496

@willthames
Copy link
Contributor Author

No backport required for 2.6.

abadger pushed a commit that referenced this pull request Oct 24, 2018
@willthames @abadger
Use kubeconfig if either context or kubeconfig is set (#47373) (#47496)
1c9551f 
* Use kubeconfig if either context or kubeconfig is set (#47373)

kubeconfig should be loaded if *either* or both of context
or kubeconfig is set (this allows picking a context and default
kubeconfig or picking a kubeconfig with default context)

Fixes #47149

(cherry picked from commit 00ccad9)

* Add changelog for k8s auth config fix
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@willthames @Tomorrow9
Use kubeconfig if either context or kubeconfig is set (ansible#47373)
2647ef1 
kubeconfig should be loaded if *either* or both of context
or kubeconfig is set (this allows picking a context and default
kubeconfig or picking a kubeconfig with default context)

Fixes ansible#47149
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. k8s shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

K8S_AUTH_* environment variables not read in Ansible 2.7
4 participants
@willthames @ansibot @fabianvf @gundalow