fix error checking if netns exists #47397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an error that occurs when attempting to see if the netns already exists on the remote device. This change will now execute `ip netns list` and check if the desired namespace is in the output. Signed-off-by: Peter Sprygada <psprygada@ansible.com>
|
Hi @privateip, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
Qalthos
pushed a commit
to Qalthos/ansible
that referenced
this pull request
Oct 22, 2018
This patch fixes an error that occurs when attempting to see if the netns already exists on the remote device. This change will now execute `ip netns list` and check if the desired namespace is in the output. Signed-off-by: Peter Sprygada <psprygada@ansible.com> (cherry picked from commit 299a5e4) Co-authored-by: Peter Sprygada <privateip@users.noreply.github.com>
abadger
pushed a commit
that referenced
this pull request
Oct 23, 2018
* [2.7] fix error checking if netns exists (#47397) This patch fixes an error that occurs when attempting to see if the netns already exists on the remote device. This change will now execute `ip netns list` and check if the desired namespace is in the output. Signed-off-by: Peter Sprygada <psprygada@ansible.com> (cherry picked from commit 299a5e4) Co-authored-by: Peter Sprygada <privateip@users.noreply.github.com> * Add changelog entry
webknjaz
removed
needs_triage
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
This patch fixes an error that occurs when attempting to see if the netns already exists on the remote device. This change will now execute `ip netns list` and check if the desired namespace is in the output. Signed-off-by: Peter Sprygada <psprygada@ansible.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an error that occurs when attempting to see if the
netns already exists on the remote device. This change will now execute
ip netns listand check if the desired namespace is in the output.Signed-off-by: Peter Sprygada psprygada@ansible.com