Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dnf immutable mutable datatypes #47434

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Handle dnf immutable mutable datatypes #47434

merged 2 commits into from
Oct 23, 2018

Conversation

maxamillion
Copy link
Contributor

SUMMARY

Backport of 46176 (cherry picked from commit 70025e7)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

@maxamillion
Handle dnf immutable mutable datatypes
95a69c5 
In DNF < 3.0 are lists, and modifying them works
In DNF >= 3.0 < 3.6 are lists, but modifying them doesn't work
In DNF >= 3.6 have been turned into tuples, to communicate that
modifying them doesn't work

Further explanation of this is available via Adam Williamson from
the Fedora QA Team.

    https://www.happyassassin.net/2018/06/27/adams-debugging-adventures-the-immutable-mutable-object/

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 70025e7)
@maxamillion
add backport changelog
c524be3 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

Hi @maxamillion, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 23, 2018
@abadger abadger merged commit b14c45a into ansible:stable-2.7 Oct 23, 2018
@abadger
Copy link
Contributor

abadger commented Oct 23, 2018

Merged fo the 2.7.1 release

@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Oct 23, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxamillion @ansibot @abadger @webknjaz